Bug 129971 - Use std::isnan in profiler/ProfileNode.cpp to fix build failure on OpenBSD
Summary: Use std::isnan in profiler/ProfileNode.cpp to fix build failure on OpenBSD
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-08 11:15 PST by Landry Breuil
Modified: 2016-01-27 15:04 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2014-03-08 11:17 PST, Landry Breuil 		ggaren: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Landry Breuil 2014-03-08 11:15:20 PST 
Build fail if using isnan() directly. Use std::isnan as it's consistent all over webkit's source code..
Comment 1 Landry Breuil 2014-03-08 11:17:26 PST 
Created attachment 226219 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-08 12:11:51 PST 
Comment on attachment 226219 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-03-08 12:12:46 PST 
Comment on attachment 226219 [details]
Patch

Rejecting attachment 226219 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226219, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5200201748840448
Comment 4 Joseph Pecoraro 2016-01-27 15:04:55 PST 
Looks like this landed a long time ago.