WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129971
Use std::isnan in profiler/ProfileNode.cpp to fix build failure on OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=129971
Summary
Use std::isnan in profiler/ProfileNode.cpp to fix build failure on OpenBSD
Landry Breuil
Reported
2014-03-08 11:15:20 PST
Build fail if using isnan() directly. Use std::isnan as it's consistent all over webkit's source code..
Attachments
Patch
(1.61 KB, patch)
2014-03-08 11:17 PST
,
Landry Breuil
ggaren
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Landry Breuil
Comment 1
2014-03-08 11:17:26 PST
Created
attachment 226219
[details]
Patch
Geoffrey Garen
Comment 2
2014-03-08 12:11:51 PST
Comment on
attachment 226219
[details]
Patch r=me
WebKit Commit Bot
Comment 3
2014-03-08 12:12:46 PST
Comment on
attachment 226219
[details]
Patch Rejecting
attachment 226219
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226219, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://webkit-queues.appspot.com/results/5200201748840448
Joseph Pecoraro
Comment 4
2016-01-27 15:04:55 PST
Looks like this landed a long time ago.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug