Bug 129965 - Use pthread_stackseg_np() to find the stack bounds on OpenBSD
Summary: Use pthread_stackseg_np() to find the stack bounds on OpenBSD
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-08 02:06 PST by Landry Breuil
Modified: 2014-03-22 09:22 PDT (History)
3 users (show)

See Also:


Attachments
Use pthread_stackseg_np on OpenBSD (1.97 KB, patch)
2014-03-08 02:11 PST, Landry Breuil
andersca: review-
Details | Formatted Diff | Diff
Use pthread_stackseg_np on OpenBSD (2.05 KB, patch)
2014-03-16 12:55 PDT, Landry Breuil
andersca: review+
Details | Formatted Diff | Diff
Use pthread_stackseg_np on OpenBSD (2.04 KB, patch)
2014-03-17 12:52 PDT, Landry Breuil
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Landry Breuil 2014-03-08 02:06:48 PST
And add an #ifndef __OpenBSD__ because we have pthread_np.h like FreeBSD but not pthread_attr_get_np()

http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_JavaScriptCore_heap_MachineStackMarker_cpp?rev=1.3
Comment 1 Landry Breuil 2014-03-08 02:11:31 PST
Created attachment 226210 [details]
Use pthread_stackseg_np on OpenBSD
Comment 2 Geoffrey Garen 2014-03-08 10:50:11 PST
Comment on attachment 226210 [details]
Use pthread_stackseg_np on OpenBSD

View in context: https://bugs.webkit.org/attachment.cgi?id=226210&action=review

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:356
> +#  ifndef __OpenBSD__

Instead of checking the compiler-provided mangled symbol, you should add an entry for OS(OPENBSD) to wtf/Platform.h, and make it mutually exclusive with OS(NETBSD).
Comment 3 Landry Breuil 2014-03-08 10:58:47 PST
(In reply to comment #2)
> (From update of attachment 226210 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226210&action=review
> 
> > Source/JavaScriptCore/heap/MachineStackMarker.cpp:356
> > +#  ifndef __OpenBSD__
> 
> Instead of checking the compiler-provided mangled symbol, you should add an entry for OS(OPENBSD) to wtf/Platform.h, and make it mutually exclusive with OS(NETBSD).

There's already one in wtf/Platform.h, dunno why i didnt use it..
Comment 4 Anders Carlsson 2014-03-16 12:30:34 PDT
Comment on attachment 226210 [details]
Use pthread_stackseg_np on OpenBSD

Please upload a new patch that uses OS(OPENBSD). Thanks!
Comment 5 Landry Breuil 2014-03-16 12:55:53 PDT
Created attachment 226855 [details]
Use pthread_stackseg_np on OpenBSD

Hand-edited patch for the win! To whoever commits it, please add the 'Reviewed by' line to please the bots...
Comment 6 Alexey Proskuryakov 2014-03-17 09:29:46 PDT
Can you upload a new patch with "Reviewed by Anders Carlsson" in ChangeLog, and mark the patch with cq? flag? In this case, all a committer needs to do is change that to cq+, which is more likely to happen soon than manually landing the patch.
Comment 7 Alexey Proskuryakov 2014-03-17 09:31:06 PDT
Comment on attachment 226855 [details]
Use pthread_stackseg_np on OpenBSD

View in context: https://bugs.webkit.org/attachment.cgi?id=226855&action=review

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:356
> +#  if !OS(OPENBSD)

We normally don't use this kind of indentation for preprocessor. Does this match something else in this file? If no, please change to plain "#if".

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:359
> +#  endif

Ditto.

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:422
> +# if OS(OPENBSD)

Ditto.
Comment 8 Landry Breuil 2014-03-17 12:52:00 PDT
Created attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

Ugh. Much easier to contribute to mozilla than to webkit..... such pain dealing with patch bureaucracy.
Comment 9 WebKit Commit Bot 2014-03-17 12:52:29 PDT
Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

Rejecting attachment 226946 [details] from review queue.

landry@openbsd.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 10 WebKit Commit Bot 2014-03-17 12:53:04 PDT
Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

Rejecting attachment 226946 [details] from commit-queue.

landry@openbsd.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 11 Landry Breuil 2014-03-17 13:03:25 PDT
Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

I hate you commit bot.
Comment 12 Alexey Proskuryakov 2014-03-17 13:17:54 PDT
Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

You don't need to ask for review when it's already reviewed.
Comment 13 WebKit Commit Bot 2014-03-22 07:31:35 PDT
Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

Clearing flags on attachment: 226946

Committed r166113: <http://trac.webkit.org/changeset/166113>