Bug 129963 – Enable DFG_JIT and LLINT on OpenBSD & NetBSD

• Status: NEW
• Component: JavaScriptCore

[Landry Breuil]

+++ This bug was initially created as a clone of Bug #128898 +++

Let's just follow freebsd on that one, it works just fine on OpenBSD, and the build breaks otherwise anyway.

[Landry Breuil]

Created attachment 226206 [details]
Enable DFG_JIT and LLINT

[Geoffrey Garen]

Comment on attachment 226206 [details]
Enable DFG_JIT and LLINT

r=me

[Landry Breuil]

What's needed for this to land now ?

[Zan Dobersek]

Comment on attachment 226206 [details]
Enable DFG_JIT and LLINT

Let's try landing then.

[WebKit Commit Bot]

Comment on attachment 226206 [details]
Enable DFG_JIT and LLINT

Rejecting attachment 226206 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 226206, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5352869498716160

[Csaba Osztrogonác]

Comment on attachment 226206 [details]
Enable DFG_JIT and LLINT

View in context: https://bugs.webkit.org/attachment.cgi?id=226206&action=review

Please update the title of the bug and the patch, if you still would like to enable DFG JIT.

> Source/WTF/ChangeLog:3
> +        Enable DFG_JIT and LLINT on OpenBSD and NetBSD

Please update it.

> Source/WTF/ChangeLog:6
> +        Reviewed by Nobody(yet).

Please don't change the original "Reviewed by NOBODY (OOPS!)."
line, because it is needed for commit queue to be able fill the 
name of the reviewer.

> Source/WTF/wtf/Platform.h:706
> -    && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD) || OS(WINDOWS)) \
> +    && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD) || OS(OPENBSD) || OS(NETBSD) || OS(WINDOWS)) \
>      && ((OS(DARWIN) && !PLATFORM(EFL)) || PLATFORM(GTK) || PLATFORM(WIN)) \
>      && (CPU(X86) || CPU(X86_64) || CPU(ARM_THUMB2) || CPU(ARM_TRADITIONAL) || CPU(ARM64) || CPU(MIPS) || CPU(SH4))
>  #define ENABLE_LLINT 1

LLINT can't be disabled anymore and that's why the patch doesn't apply anymore.