RESOLVED FIXED 129961
Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner 
https://bugs.webkit.org/show_bug.cgi?id=129961
Summary Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
zalan
Reported 2014-03-07 22:02:19 PST
Currently, we take the software rendering path for hiDPI compositing test content.
Attachments
Patch (9.92 KB, patch)
2014-03-07 22:16 PST, zalan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (544.86 KB, application/zip)
2014-03-07 23:07 PST, Build Bot 		no flags
Details
Patch (12.43 KB, patch)
2014-03-10 19:14 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (512.97 KB, application/zip)
2014-03-10 22:22 PDT, Build Bot 		no flags
Details
Patch (17.97 KB, patch)
2014-03-11 08:34 PDT, zalan 		zalan: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-03-07 22:16:01 PST
Created attachment 226202 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-03-07 22:21:04 PST
Comment on attachment 226202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226202&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:930 > + @"AppleMagnifiedMode": @NO, Probably just remove this. > Tools/WebKitTestRunner/mac/main.mm:34 > + @"AppleMagnifiedMode": @NO, Remove.
Build Bot
Comment 3 2014-03-07 23:06:50 PST
Comment on attachment 226202 [details] Patch Attachment 226202 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6182253537263616 New failing tests: fast/borders/hidpi-border-clipping-right-after-move.html compositing/hidpi-compositing-vs-non-compositing-check-on-testing-framework.html
Build Bot
Comment 4 2014-03-07 23:07:00 PST
Created attachment 226203 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
zalan
Comment 5 2014-03-10 19:14:17 PDT
Created attachment 226367 [details] Patch
zalan
Comment 6 2014-03-10 19:14:38 PDT
Comment on attachment 226367 [details] Patch EWS testing
Build Bot
Comment 7 2014-03-10 22:22:38 PDT
Comment on attachment 226367 [details] Patch Attachment 226367 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4791742842798080 New failing tests: svg/custom/masking-clipping-hidpi.svg
Build Bot
Comment 8 2014-03-10 22:22:41 PDT
Created attachment 226388 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
zalan
Comment 9 2014-03-11 08:34:49 PDT
Created attachment 226428 [details] Patch
zalan
Comment 10 2014-03-11 08:35:04 PDT
Comment on attachment 226428 [details] Patch EWS testing
zalan
Comment 11 2014-03-12 08:35:24 PDT
Committed r165470: <http://trac.webkit.org/changeset/165470>
Benjamin Poulain
Comment 12 2014-03-12 20:39:25 PDT
compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?)
zalan
Comment 13 2014-03-12 20:43:11 PDT
(In reply to comment #12) > compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?) thanks. It's ML wk2 debug only, so I'll just skip it for now and will come back to it.
zalan
Comment 14 2014-03-12 21:32:29 PDT
(In reply to comment #13) > (In reply to comment #12) > > compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?) > > thanks. It's ML wk2 debug only, so I'll just skip it for now and will come back to it. https://bugs.webkit.org/show_bug.cgi?id=130175
Note You need to log in before you can comment on or make changes to this bug.