Bug 129961 - Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
Summary: Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks: 129859
  Show dependency treegraph
 
Reported: 2014-03-07 22:02 PST by zalan
Modified: 2014-03-12 21:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.92 KB, patch)
2014-03-07 22:16 PST, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (544.86 KB, application/zip)
2014-03-07 23:07 PST, Build Bot
no flags Details
Patch (12.43 KB, patch)
2014-03-10 19:14 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (512.97 KB, application/zip)
2014-03-10 22:22 PDT, Build Bot
no flags Details
Patch (17.97 KB, patch)
2014-03-11 08:34 PDT, zalan
zalan: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-03-07 22:02:19 PST
Currently, we take the software rendering path for hiDPI compositing test content.
Comment 1 zalan 2014-03-07 22:16:01 PST
Created attachment 226202 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-03-07 22:21:04 PST
Comment on attachment 226202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226202&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:930
> +        @"AppleMagnifiedMode": @NO,

Probably just remove this.

> Tools/WebKitTestRunner/mac/main.mm:34
> +        @"AppleMagnifiedMode": @NO,

Remove.
Comment 3 Build Bot 2014-03-07 23:06:50 PST
Comment on attachment 226202 [details]
Patch

Attachment 226202 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6182253537263616

New failing tests:
fast/borders/hidpi-border-clipping-right-after-move.html
compositing/hidpi-compositing-vs-non-compositing-check-on-testing-framework.html
Comment 4 Build Bot 2014-03-07 23:07:00 PST
Created attachment 226203 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 zalan 2014-03-10 19:14:17 PDT
Created attachment 226367 [details]
Patch
Comment 6 zalan 2014-03-10 19:14:38 PDT
Comment on attachment 226367 [details]
Patch

EWS testing
Comment 7 Build Bot 2014-03-10 22:22:38 PDT
Comment on attachment 226367 [details]
Patch

Attachment 226367 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4791742842798080

New failing tests:
svg/custom/masking-clipping-hidpi.svg
Comment 8 Build Bot 2014-03-10 22:22:41 PDT
Created attachment 226388 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 zalan 2014-03-11 08:34:49 PDT
Created attachment 226428 [details]
Patch
Comment 10 zalan 2014-03-11 08:35:04 PDT
Comment on attachment 226428 [details]
Patch

EWS testing
Comment 11 zalan 2014-03-12 08:35:24 PDT
Committed r165470: <http://trac.webkit.org/changeset/165470>
Comment 12 Benjamin Poulain 2014-03-12 20:39:25 PDT
compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?)
Comment 13 zalan 2014-03-12 20:43:11 PDT
(In reply to comment #12)
> compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?)

thanks. It's ML wk2 debug only, so I'll just skip it for now and will come back to it.
Comment 14 zalan 2014-03-12 21:32:29 PDT
(In reply to comment #13)
> (In reply to comment #12)
> > compositing/hidpi-simple-container-layer-on-device-pixel.html fails since this commit. Can you please have a look (or revert?)
> 
> thanks. It's ML wk2 debug only, so I'll just skip it for now and will come back to it.

https://bugs.webkit.org/show_bug.cgi?id=130175