Bug 129945 - .cfi directives in LowLevelInterpreter.cpp are providing no benefit
Summary: .cfi directives in LowLevelInterpreter.cpp are providing no benefit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 17:17 PST by Michael Saboff
Modified: 2014-03-07 19:28 PST (History)
0 users

See Also:

Attachments
Patch (2.32 KB, patch)
2014-03-07 17:56 PST, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-03-07 17:17:09 PST 
The .cfi (call frame information) directives in llint/LowLevelInterpreter.cpp currently only wrap the LLInt assembly language with .cfi_startproc and .cfi_endproc.  The other .cfi unwind directives have been disabled and aren't providing any benefit.
Comment 1 Michael Saboff 2014-03-07 17:56:11 PST 
Created attachment 226194 [details]
Patch
Comment 2 Mark Lam 2014-03-07 18:30:13 PST 
Comment on attachment 226194 [details]
Patch

r=me
Comment 3 Michael Saboff 2014-03-07 19:28:05 PST 
Committed r165320: <http://trac.webkit.org/changeset/165320>