Bug 129935 - Make it possible to copy WebKit2 headers to WebKit.framework
Summary: Make it possible to copy WebKit2 headers to WebKit.framework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 15:58 PST by Anders Carlsson
Modified: 2014-03-07 16:12 PST (History)
0 users

See Also:

Attachments
Patch (7.97 KB, patch)
2014-03-07 16:02 PST, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-03-07 15:58:07 PST 
Make it possible to copy WebKit2 headers to WebKit.framework
Comment 1 Anders Carlsson 2014-03-07 16:02:11 PST 
Created attachment 226179 [details]
Patch
Comment 2 mitz 2014-03-07 16:08:43 PST 
Comment on attachment 226179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226179&action=review

> Source/WebKit/mac/migrate-headers.sh:37
> +    export WEBKIT2_FRAMEWORKS_DIR="`eval 'echo ${WEBKIT2_FRAMEWORKS_DIR_Production}'/WebKit2.framework`"

Why is this using eval?
Comment 3 Anders Carlsson 2014-03-07 16:12:19 PST 
(In reply to comment #2)
> (From update of attachment 226179 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226179&action=review
> 
> > Source/WebKit/mac/migrate-headers.sh:37
> > +    export WEBKIT2_FRAMEWORKS_DIR="`eval 'echo ${WEBKIT2_FRAMEWORKS_DIR_Production}'/WebKit2.framework`"
> 
> Why is this using eval?

I don't know :( Because that's what's used in the other variable...
Comment 4 Anders Carlsson 2014-03-07 16:12:36 PST 
Committed r165298: <http://trac.webkit.org/changeset/165298>