Bug 129929 – input event doesn't fire when <input type=range> value is changed by pressing the keyboard arrows

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Lorenzo Tilve]

The 'input' event is fired when moving the slider with the mouse, but it's not when using the keyboard. The 'change' event is properly sent in both cases.

It can be tested here http://jsfiddle.net/ltilve/T8767/

The behaviour should be the same with independence of the device, dispatching the 'input' event in both cases.

Is the same issue reported at https://crbug.com/345611

[Lorenzo Tilve]

Created attachment 226175 [details]
Patch

[Zan Dobersek]

Comment on attachment 226175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226175&action=review

> Source/WebCore/html/RangeInputType.cpp:241
> -        TextFieldEventBehavior eventBehavior = DispatchChangeEvent;
> +        TextFieldEventBehavior eventBehavior = DispatchInputAndChangeEvent;
>          setValueAsDecimal(newValue, eventBehavior, IGNORE_EXCEPTION);

DispatchInputAndChangeEvent can be inlined directly into the setValueAsDecimal() call.

[Lorenzo Tilve]

Created attachment 227126 [details]
Patch

Applied suggested modification

[WebKit Commit Bot]

Comment on attachment 227126 [details]
Patch

Clearing flags on attachment: 227126

Committed r165954: <http://trac.webkit.org/changeset/165954>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Lucas Forschler]

Mass move bugs into the DOM component.