Bug 129929 - input event doesn't fire when <input type=range> value is changed by pressing the keyboard arrows
Summary: input event doesn't fire when <input type=range> value is changed by pressing...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 15:14 PST by Lorenzo Tilve
Modified: 2019-02-06 09:18 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.58 KB, patch)
2014-03-07 15:38 PST, Lorenzo Tilve
no flags Details | Formatted Diff | Diff
Patch (5.59 KB, patch)
2014-03-18 16:06 PDT, Lorenzo Tilve
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Tilve 2014-03-07 15:14:40 PST
The 'input' event is fired when moving the slider with the mouse, but it's not when using the keyboard. The 'change' event is properly sent in both cases.

It can be tested here http://jsfiddle.net/ltilve/T8767/

The behaviour should be the same with independence of the device, dispatching the 'input' event in both cases.

Is the same issue reported at https://crbug.com/345611
Comment 1 Lorenzo Tilve 2014-03-07 15:38:47 PST
Created attachment 226175 [details]
Patch
Comment 2 Zan Dobersek 2014-03-18 12:26:07 PDT
Comment on attachment 226175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226175&action=review

> Source/WebCore/html/RangeInputType.cpp:241
> -        TextFieldEventBehavior eventBehavior = DispatchChangeEvent;
> +        TextFieldEventBehavior eventBehavior = DispatchInputAndChangeEvent;
>          setValueAsDecimal(newValue, eventBehavior, IGNORE_EXCEPTION);

DispatchInputAndChangeEvent can be inlined directly into the setValueAsDecimal() call.
Comment 3 Lorenzo Tilve 2014-03-18 16:06:12 PDT
Created attachment 227126 [details]
Patch

Applied suggested modification
Comment 4 WebKit Commit Bot 2014-03-20 01:57:08 PDT
Comment on attachment 227126 [details]
Patch

Clearing flags on attachment: 227126

Committed r165954: <http://trac.webkit.org/changeset/165954>
Comment 5 WebKit Commit Bot 2014-03-20 01:57:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Lucas Forschler 2019-02-06 09:18:41 PST
Mass move bugs into the DOM component.