Bug 129927 - Revert bug 19975
Summary: Revert bug 19975
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Other
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
: 129922 129923 129924 129925 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-03-07 15:06 PST by Landry Breuil
Modified: 2015-02-26 07:21 PST (History)
6 users (show)

See Also:

Attachments
Revert bug 19975 (1.50 KB, patch)
2014-03-07 15:09 PST, Landry Breuil 		no flags Details | Formatted Diff | Diff
Revert bug 19975 (1.55 KB, patch)
2014-03-08 01:12 PST, Landry Breuil 		no flags Details | Formatted Diff | Diff
Patch for landing (1.43 KB, patch)
2015-02-26 06:27 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch for landing (1.38 KB, patch)
2015-02-26 06:30 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Landry Breuil 2014-03-07 15:06:02 PST 
Now that gcc 4.7 is required bug 19975 gets in the way.
Comment 1 Landry Breuil 2014-03-07 15:09:24 PST 
Created attachment 226173 [details]
Revert bug 19975

seems mail.webkit.org is down..
Comment 2 WebKit Commit Bot 2014-03-07 15:11:18 PST 
Attachment 226173 [details] did not pass style-queue:


ERROR: Source/WTF/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Landry Breuil 2014-03-08 01:12:13 PST 
Created attachment 226205 [details]
Revert bug 19975

Add bug URL
Comment 4 Landry Breuil 2014-03-08 01:14:32 PST 
*** Bug 129922 has been marked as a duplicate of this bug. ***
Comment 5 Landry Breuil 2014-03-08 01:14:41 PST 
*** Bug 129923 has been marked as a duplicate of this bug. ***
Comment 6 Landry Breuil 2014-03-08 01:14:49 PST 
*** Bug 129924 has been marked as a duplicate of this bug. ***
Comment 7 Landry Breuil 2014-03-08 01:14:57 PST 
*** Bug 129925 has been marked as a duplicate of this bug. ***
Comment 8 Landry Breuil 2014-03-08 01:47:42 PST 
Forgot to explain: now on openbsd the build fails without this patch because isfinite and signbit are defined twice.
Comment 9 Andreas Kling 2014-03-08 13:31:08 PST 
Comment on attachment 226205 [details]
Revert bug 19975

r=me
Comment 10 WebKit Commit Bot 2014-03-08 13:32:49 PST 
Comment on attachment 226205 [details]
Revert bug 19975

Rejecting attachment 226205 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226205, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/4913826214445056
Comment 11 Antoine Jacoutot 2014-04-19 05:43:30 PDT 
Hi. What's the hold for this patch? This is preventing me from building WebKit in JHBuild. Since it only impacts OpenBSD, I think it is pretty safe.
Thanks :-)
Comment 12 Csaba Osztrogonác 2015-02-26 06:27:36 PST 
Created attachment 247424 [details]
Patch for landing
Comment 13 Csaba Osztrogonác 2015-02-26 06:29:02 PST 
(In reply to comment #11)
> Hi. What's the hold for this patch? This is preventing me from building
> WebKit in JHBuild. Since it only impacts OpenBSD, I think it is pretty safe.
> Thanks :-)

The problem was that you removed this line "Reviewed by NOBODY (OOPS!).".
Comment 14 Csaba Osztrogonác 2015-02-26 06:30:05 PST 
Created attachment 247425 [details]
Patch for landing
Comment 15 WebKit Commit Bot 2015-02-26 07:21:32 PST 
Comment on attachment 247425 [details]
Patch for landing

Clearing flags on attachment: 247425

Committed r180674: <http://trac.webkit.org/changeset/180674>
Comment 16 WebKit Commit Bot 2015-02-26 07:21:37 PST 
All reviewed patches have been landed.  Closing bug.