Bug 129926 - Add Remote Control command support to HTMLMediaElement
Summary: Add Remote Control command support to HTMLMediaElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 14:59 PST by Jer Noble
Modified: 2014-03-14 10:23 PDT (History)
1 user (show)

See Also:

Attachments
Patch (13.18 KB, patch)
2014-03-07 15:04 PST, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-03-07 14:59:46 PST 
Add Remote Control command support to HTLMediaElement
Comment 1 Jer Noble 2014-03-07 15:04:55 PST 
Created attachment 226172 [details]
Patch
Comment 2 Eric Carlson 2014-03-13 14:37:47 PDT 
Comment on attachment 226172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3059
> +    } else
> +        setPlaybackRate(nextScanRate());
> +}

Do we really want to increase the scan rate to infinity (and beyond)?

> Source/WebCore/html/HTMLMediaElement.cpp:5937
> +        { } // Do nothing

Nit: I don't think "{ }" is necessary, won't a semi-colon work?
Comment 3 Jer Noble 2014-03-13 14:47:07 PDT 
(In reply to comment #2)
> (From update of attachment 226172 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:3059
> > +    } else
> > +        setPlaybackRate(nextScanRate());
> > +}
> 
> Do we really want to increase the scan rate to infinity (and beyond)?

We'll max out at ScanMaximumRate (8x) inside of nextScanRate().

> > Source/WebCore/html/HTMLMediaElement.cpp:5937
> > +        { } // Do nothing
> 
> Nit: I don't think "{ }" is necessary, won't a semi-colon work?

Clang++ complains about only a semicolon, and explicitly suggests "{ }" for an empty statement.
Comment 4 Eric Carlson 2014-03-13 16:08:33 PDT 
Comment on attachment 226172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review

>>> Source/WebCore/html/HTMLMediaElement.cpp:3059
>>> +}
>> 
>> Do we really want to increase the scan rate to infinity (and beyond)?
> 
> We'll max out at ScanMaximumRate (8x) inside of nextScanRate().

Oops, I looked right past that!
Comment 5 Jer Noble 2014-03-14 10:23:07 PDT 
Committed r165628: <http://trac.webkit.org/changeset/165628>