this is going to be sweet!
Created attachment 226266 [details] Debugger dashboard - paused at full size
Created attachment 226267 [details] paused at small size, full width
Created attachment 226268 [details] oops, dup
Created attachment 226269 [details] paused at small size, narrow width
Created attachment 226274 [details] the patch
this patch depends on 129898, so the bots will have trouble.
Comment on attachment 226274 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=226274&action=review > Source/WebInspectorUI/UserInterface/Models/DebuggerDashboard.js:35 > + __proto__: WebInspector.Object.prototype, > + > +}; Nit: stray newline. > Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css:63 > + background-color: #999; Nit: rgb(153, 153, 153) > Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css:73 > + from { opacity: 0.7; -webkit-transform: scale(1); } > + to { opacity: 1; -webkit-transform: scale(1.1); } Not sure I would do scale. But I would have to see it. > Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js:58 > +WebInspector.DebuggerDashboardView.FunctionIconStyleClassName = WebInspector.CallFrameTreeElement.FunctionIconStyleClassName; > +WebInspector.DebuggerDashboardView.EventListenerIconStyleClassName = WebInspector.CallFrameTreeElement.EventListenerIconStyleClassName; There are other places in the code where we cross reference directly. I like this approach better though. > Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js:85 > + // This is more than likely an event listener function with an "on" prefix and it is > + // as long or longer than the shortest event listener name -- "oncut". > + if (callFrame.functionName && callFrame.functionName.startsWith("on") && callFrame.functionName.length >= 5) > + iconClassName = WebInspector.DebuggerDashboardView.EventListenerIconStyleClassName; We should probably have a helper for this logic. I think this is the third copy of it.
Comment on attachment 226274 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=226274&action=review >> Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css:73 >> + to { opacity: 1; -webkit-transform: scale(1.1); } > > Not sure I would do scale. But I would have to see it. It's subtle enough that it looks more like a pulse instead of a corny ad. But it could definitely be tweaked further with your help. The glyph could probably be darker and have some sort of bezel to make it stand out better. >> Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js:85 >> + iconClassName = WebInspector.DebuggerDashboardView.EventListenerIconStyleClassName; > > We should probably have a helper for this logic. I think this is the third copy of it. This version omits the native call frame check since we can't pause in/on those as the top call frame (AFAIK?)
Committed r165383: <http://trac.webkit.org/changeset/165383>