Bug 129908 - [Mac] Notify system malloc of fake memory pressure.
Summary: [Mac] Notify system malloc of fake memory pressure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 13:35 PST by Andreas Kling
Modified: 2014-03-07 14:10 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.88 KB, patch)
2014-03-07 13:40 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-07 13:35:56 PST
After fixing the leak in r165252, I was surprised to find that it didn't
show up on memory test bots. It turns out that while the memory is now
getting freed, the system malloc implementation doesn't actually release
pages back to the OS until there is memory pressure.

Since we are just faking the memory pressure on bots, we have to let
system malloc in on the fun, so we can get representative numbers.
With this change, we should finally see the effect of not leaking the
URLRequest object tree.
Comment 1 Andreas Kling 2014-03-07 13:40:13 PST
Created attachment 226160 [details]
Patch
Comment 2 Andreas Kling 2014-03-07 14:10:14 PST
Comment on attachment 226160 [details]
Patch

Clearing flags on attachment: 226160

Committed r165292: <http://trac.webkit.org/changeset/165292>
Comment 3 Andreas Kling 2014-03-07 14:10:19 PST
All reviewed patches have been landed.  Closing bug.