Bug 129904 - REGRESSION(165267): Broke a webkitpy unit tests
Summary: REGRESSION(165267): Broke a webkitpy unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 13:06 PST by Martin Robinson
Modified: 2014-03-07 13:27 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2014-03-07 13:09 PST, Martin Robinson 		jhoneycutt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-03-07 13:06:47 PST 
gtk.py used to assume that the build was an autotools build unless it could prove otherwise. Now that CMake is the default, we should assume it's a CMake build unless proven otherwise. This matters because it changes the expected results on systems where we can detect neither a CMake or an autotools build. We should assume a CMake build so that "--gtk" is used instead of "--gtkautotools" for invoking commands.
Comment 1 Martin Robinson 2014-03-07 13:09:37 PST 
Created attachment 226153 [details]
Patch
Comment 2 Jon Honeycutt 2014-03-07 13:17:28 PST 
Comment on attachment 226153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226153&action=review

r=me

> Tools/Scripts/webkitpy/port/gtk.py:57
>      def _is_cmake_build(self):
> -        return os.path.exists(self._build_path('CMakeCache.txt'))
> +        return not os.path.exists(self._build_path('config.log'))

A comment about this would help readability.
Comment 3 Martin Robinson 2014-03-07 13:27:10 PST 
Committed r165284: <http://trac.webkit.org/changeset/165284>