Bug 129902 - [GTK] Improve ninja detection in webkitdirs.pm
Summary: [GTK] Improve ninja detection in webkitdirs.pm
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
Depends on:
Reported: 2014-03-07 12:54 PST by Martin Robinson
Modified: 2014-03-15 15:44 PDT (History)
4 users (show)

See Also:

Patch (1.11 KB, patch)
2014-03-07 12:57 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (1.28 KB, patch)
2014-03-14 19:07 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-03-07 12:54:46 PST
We should avoid this spurious output.
Comment 1 Martin Robinson 2014-03-07 12:57:03 PST
Created attachment 226152 [details]
Comment 2 Daniel Bates 2014-03-13 19:02:28 PDT
This issue was fixed in <http://trac.webkit.org/changeset/165541> (bug #130129). Maybe it would be better to use which(1) to detect whether ninja is in the user's path as opposed to calling ninja and redirecting stderr (thereby silencing the "command not found" error) as in the aforementioned change set?
Comment 3 Csaba Osztrogonác 2014-03-14 01:46:59 PDT
Comment on attachment 226152 [details]

It is really better fix than r165541, r=me.
(but cq-, because it is in conflict with r165541.)
Comment 4 Martin Robinson 2014-03-14 09:01:49 PDT
I think this is a good bug to switch to 'which' and also to detect ninja-build as well (as it is called on Fedora).
Comment 5 Martin Robinson 2014-03-14 19:07:39 PDT
Created attachment 226790 [details]
Comment 6 Martin Robinson 2014-03-15 15:44:54 PDT
Comment on attachment 226790 [details]

Clearing flags on attachment: 226790

Committed r165684: <http://trac.webkit.org/changeset/165684>
Comment 7 Martin Robinson 2014-03-15 15:44:58 PDT
All reviewed patches have been landed.  Closing bug.