Bug 129897 - [iOS] Add an updateID to visibleContentRect updates which is passed back in layer transactions, so we know whether transactions are stale
Summary: [iOS] Add an updateID to visibleContentRect updates which is passed back in l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 12:16 PST by Simon Fraser (smfr)
Modified: 2014-03-07 12:46 PST (History)
3 users (show)

See Also:

Attachments
Patch (13.85 KB, patch)
2014-03-07 12:18 PST, Simon Fraser (smfr) 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-03-07 12:16:50 PST 
[iOS] Add an updateID to visibleContentRect updates which is passed back in layer transactions, so we know whether transactions are stale
Comment 1 Simon Fraser (smfr) 2014-03-07 12:18:42 PST 
Created attachment 226147 [details]
Patch
Comment 2 Benjamin Poulain 2014-03-07 12:22:18 PST 
Comment on attachment 226147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226147&action=review

> Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:47
> +    VisibleContentRectUpdateInfo(const WebCore::FloatRect& exposedRect, const WebCore::FloatRect& unobscuredRect, const WebCore::FloatRect& customFixedPositionRect, double scale, uint64_t updateID, bool inStableState)

I would put the update ID first for some reason...

> Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:78
> +    // Note: the comparison doesn't include updateID.

I agree this is correct but you should probably say why here.
Comment 3 Simon Fraser (smfr) 2014-03-07 12:46:50 PST 
https://trac.webkit.org/r165279