WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129897
[iOS] Add an updateID to visibleContentRect updates which is passed back in layer transactions, so we know whether transactions are stale
https://bugs.webkit.org/show_bug.cgi?id=129897
Summary
[iOS] Add an updateID to visibleContentRect updates which is passed back in l...
Simon Fraser (smfr)
Reported
2014-03-07 12:16:50 PST
[iOS] Add an updateID to visibleContentRect updates which is passed back in layer transactions, so we know whether transactions are stale
Attachments
Patch
(13.85 KB, patch)
2014-03-07 12:18 PST
,
Simon Fraser (smfr)
benjamin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2014-03-07 12:18:42 PST
Created
attachment 226147
[details]
Patch
Benjamin Poulain
Comment 2
2014-03-07 12:22:18 PST
Comment on
attachment 226147
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=226147&action=review
> Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:47 > + VisibleContentRectUpdateInfo(const WebCore::FloatRect& exposedRect, const WebCore::FloatRect& unobscuredRect, const WebCore::FloatRect& customFixedPositionRect, double scale, uint64_t updateID, bool inStableState)
I would put the update ID first for some reason...
> Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:78 > + // Note: the comparison doesn't include updateID.
I agree this is correct but you should probably say why here.
Simon Fraser (smfr)
Comment 3
2014-03-07 12:46:50 PST
https://trac.webkit.org/r165279
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug