Bug 129886 - run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
Summary: run-jsc-stress-tests doesn't eagerly report test failures when using the shel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 08:57 PST by Mark Hahnenberg
Modified: 2014-03-28 13:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.46 KB, patch)
2014-03-07 10:37 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-07 08:57:44 PST 
It should.
Comment 1 Mark Hahnenberg 2014-03-07 10:37:18 PST 
Created attachment 226137 [details]
Patch
Comment 2 Mark Lam 2014-03-07 11:03:43 PST 
Comment on attachment 226137 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-03-07 11:34:36 PST 
Comment on attachment 226137 [details]
Patch

Clearing flags on attachment: 226137

Committed r165274: <http://trac.webkit.org/changeset/165274>
Comment 4 WebKit Commit Bot 2014-03-07 11:34:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Filip Pizlo 2014-03-28 13:45:05 PDT 
This made all error reporting super ugly because of the way that "1>&2" was added.  Apparently when you add it without a space after the prefixCommand(), it somehow tells shell to duplicate the output.  Don't ask why.

Anyway, the moral of the story is: if you make changes to error handling in run-jsc-stress-tests you should test the error handling by locally breaking a test.

I'll fix it.