Bug 129876 - Syntax error in the sandbox profile for Adobe Flash plugin
Summary: Syntax error in the sandbox profile for Adobe Flash plugin
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.8
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 04:07 PST by Dmitry Rodionov
Modified: 2014-03-18 09:29 PDT (History)
12 users (show)

See Also:

Attachments
Patch fixing this bug (646 bytes, patch)
2014-03-07 04:45 PST, Dmitry Rodionov 		no flags Details | Formatted Diff | Diff
The proper patch for the bug (1.48 KB, patch)
2014-03-08 03:08 PST, Dmitry Rodionov 		no flags Details | Formatted Diff | Diff
Fixed proper patch (1.48 KB, patch)
2014-03-08 11:01 PST, Dmitry Rodionov 		sam: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Rodionov 2014-03-07 04:07:02 PST 
Syntax error in file Source/WebKit2/Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb, line 31:
a regex string literal should start with a «#» (number) sign.

>> 31: (home-library-regex "/Application Support/Macromedia/ss\.(cfg|cfn|sgn)$"))
Comment 1 Dmitry Rodionov 2014-03-07 04:45:25 PST 
Created attachment 226116 [details]
Patch fixing this bug
Comment 2 Dmitry Rodionov 2014-03-08 03:08:35 PST 
Created attachment 226212 [details]
The proper patch for the bug
Comment 3 Geoffrey Garen 2014-03-08 10:48:10 PST 
Comment on attachment 226212 [details]
The proper patch for the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=226212&action=review

> Source/WebKit2/ChangeLog:8
> +        A regex string literal should start with a «#» (numbert) sign (line 31).

Please us ASCII quotes.

"numbert" should be "number".
Comment 4 Geoffrey Garen 2014-03-08 10:48:19 PST 
*use
Comment 5 Dmitry Rodionov 2014-03-08 11:01:36 PST 
Created attachment 226216 [details]
Fixed proper patch
Comment 6 Dmitry Rodionov 2014-03-08 11:03:02 PST 
(In reply to comment #3)
> (From update of attachment 226212 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226212&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        A regex string literal should start with a «#» (numbert) sign (line 31).
> 
> Please us ASCII quotes.
> 
> "numbert" should be "number".

Sorry for that, fixed now with the last patch @ 2014-03-08 11:01 PST
Comment 7 Alexey Proskuryakov 2014-03-08 13:37:56 PST 
What is the observable consequence of this issue? Is it that we allow reading from e.g. ~/Library/Application Support/Macromedia/ss<any single character>cfg?

If it's an actual syntax error, then I'm not sure how it is detected - the profile compiles successfully when loading Flash. Is the error you posted printed out by some verification tool?
Comment 8 Ivan Krstić 2014-03-09 01:04:41 PST 
This is not an error.
Comment 9 Sam Weinig 2014-03-10 18:02:43 PDT 
Comment on attachment 226216 [details]
Fixed proper patch

r-ing given Ivan's comment.
Comment 10 Alexey Proskuryakov 2014-03-18 09:29:24 PDT 
(In reply to comment #8)
> This is not an error.

Is it a mistake that would be good to fix? It seems to me that the patch is correct, despite the report lacking a rationale.