Bug 129876 – Syntax error in the sandbox profile for Adobe Flash plugin

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

[Dmitry Rodionov]

Syntax error in file Source/WebKit2/Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb, line 31:
a regex string literal should start with a «#» (number) sign.

>> 31: (home-library-regex "/Application Support/Macromedia/ss\.(cfg|cfn|sgn)$"))

[Dmitry Rodionov]

Created attachment 226116 [details]
Patch fixing this bug

[Dmitry Rodionov]

Created attachment 226212 [details]
The proper patch for the bug

[Geoffrey Garen]

Comment on attachment 226212 [details]
The proper patch for the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=226212&action=review

> Source/WebKit2/ChangeLog:8
> +        A regex string literal should start with a «#» (numbert) sign (line 31).

Please us ASCII quotes.

"numbert" should be "number".

[Geoffrey Garen]

*use

[Dmitry Rodionov]

Created attachment 226216 [details]
Fixed proper patch

[Dmitry Rodionov]

(In reply to comment #3)
> (From update of attachment 226212 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226212&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        A regex string literal should start with a «#» (numbert) sign (line 31).
> 
> Please us ASCII quotes.
> 
> "numbert" should be "number".

Sorry for that, fixed now with the last patch @ 2014-03-08 11:01 PST

[Alexey Proskuryakov]

What is the observable consequence of this issue? Is it that we allow reading from e.g. ~/Library/Application Support/Macromedia/ss<any single character>cfg?

If it's an actual syntax error, then I'm not sure how it is detected - the profile compiles successfully when loading Flash. Is the error you posted printed out by some verification tool?

[Ivan Krstić]

This is not an error.

[Sam Weinig]

Comment on attachment 226216 [details]
Fixed proper patch

r-ing given Ivan's comment.

[Alexey Proskuryakov]

(In reply to comment #8)
> This is not an error.

Is it a mistake that would be good to fix? It seems to me that the patch is correct, despite the report lacking a rationale.