Bug 129875 - [EFL] Modify accelerated compositing related functions in ewk_view.
Summary: [EFL] Modify accelerated compositing related functions in ewk_view.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Hyowon Kim
URL:
Keywords:
Depends on: 129676
Blocks: 79766
  Show dependency treegraph
 
Reported: 2014-03-07 03:15 PST by Hyowon Kim
Modified: 2014-03-11 01:44 PDT (History)
7 users (show)

See Also:


Attachments
Patch (9.30 KB, patch)
2014-03-08 22:03 PST, Hyowon Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hyowon Kim 2014-03-07 03:15:45 PST
The compositing object will be created when root layer is attached.
So we don't need to expose the create function.
And show(), hide() and resize() for compositing object are needed.
Comment 1 Hyowon Kim 2014-03-08 22:03:30 PST
Created attachment 226249 [details]
Patch
Comment 2 Gyuyoung Kim 2014-03-09 16:54:00 PDT
Comment on attachment 226249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review

rs=me. However, someone else might wanna have a final look before landing.

> Source/WebKit/efl/ewk/ewk_view.cpp:989
> +        evas_object_image_size_set(priv->compositingObject.get(), w, h);

It would be good if we use "width, height"  instead of "w, h".
Comment 3 Ryuan Choi 2014-03-09 23:16:43 PDT
Comment on attachment 226249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:987
> +    if (priv->compositingObject) {

Should we still use extra compositingObject ?
Comment 4 Hyowon Kim 2014-03-10 19:42:04 PDT
(In reply to comment #3)
> (From update of attachment 226249 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:987
> > +    if (priv->compositingObject) {
> 
> Should we still use extra compositingObject ?

We can integrate accelerated compositing on compositingObject into smartData->backing_store in the next step.
Comment 5 Ryuan Choi 2014-03-10 21:24:10 PDT
Landed at http://trac.webkit.org/changeset/165428