Bug 129875 – [EFL] Modify accelerated compositing related functions in ewk_view.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Hyowon Kim]

The compositing object will be created when root layer is attached.
So we don't need to expose the create function.
And show(), hide() and resize() for compositing object are needed.

[Hyowon Kim]

Created attachment 226249 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 226249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review

rs=me. However, someone else might wanna have a final look before landing.

> Source/WebKit/efl/ewk/ewk_view.cpp:989
> +        evas_object_image_size_set(priv->compositingObject.get(), w, h);

It would be good if we use "width, height"  instead of "w, h".

[Ryuan Choi]

Comment on attachment 226249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:987
> +    if (priv->compositingObject) {

Should we still use extra compositingObject ?

[Hyowon Kim]

(In reply to comment #3)
> (From update of attachment 226249 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:987
> > +    if (priv->compositingObject) {
> 
> Should we still use extra compositingObject ?

We can integrate accelerated compositing on compositingObject into smartData->backing_store in the next step.

[Ryuan Choi]

Landed at http://trac.webkit.org/changeset/165428