Bug 129866 - Remove FFTFrameMKL
Summary: Remove FFTFrameMKL
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-03-07 00:08 PST by Gergő Balogh
Modified: 2014-03-07 03:57 PST (History)
8 users (show)

See Also:

patch (11.98 KB, patch)
2014-03-07 00:14 PST, Gergő Balogh
ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff
patch changelog fix (12.00 KB, patch)
2014-03-07 01:36 PST, Gergő Balogh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gergő Balogh 2014-03-07 00:08:39 PST
The FFTFrameMKL.ccp is never used currently. It is guarded by a USE (WEBAUDIO_MKL) macro which is never enabled, which should be also removed.
Comment 1 Gergő Balogh 2014-03-07 00:14:55 PST
Created attachment 226090 [details]
Comment 2 Csaba Osztrogonác 2014-03-07 00:58:03 PST
Comment on attachment 226090 [details]

LGTM, but please mention in the changelog too why we remove it.
Comment 3 Gergő Balogh 2014-03-07 01:36:06 PST
Created attachment 226096 [details]
patch changelog fix
Comment 4 WebKit Commit Bot 2014-03-07 03:57:14 PST
Comment on attachment 226096 [details]
patch changelog fix

Clearing flags on attachment: 226096

Committed r165256: <http://trac.webkit.org/changeset/165256>
Comment 5 WebKit Commit Bot 2014-03-07 03:57:17 PST
All reviewed patches have been landed.  Closing bug.