RESOLVED FIXED 129861
Subpixel rendering: Simple compositing container layer (isSimpleContainerCompositingLayer) paints to wrong position. 
https://bugs.webkit.org/show_bug.cgi?id=129861
Summary Subpixel rendering: Simple compositing container layer (isSimpleContainerComp...
zalan
Reported 2014-03-06 21:35:59 PST
integral pixel snapping here: RenderLayerBacking::backgroundBox(), here: GraphicsLayer::setContentsRect() and here RenderLayerBacking::updateCompositedBounds
Attachments
test case (1.07 KB, text/html)
2014-03-06 21:43 PST, zalan 		no flags
Details
Patch (14.34 KB, patch)
2014-03-08 11:41 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (14.60 KB, patch)
2014-03-08 12:06 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (18.82 KB, patch)
2014-03-08 12:29 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (19.20 KB, patch)
2014-03-08 12:40 PST, zalan 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (592.57 KB, application/zip)
2014-03-08 13:27 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (475.75 KB, application/zip)
2014-03-08 13:45 PST, Build Bot 		no flags
Details
Patch (19.20 KB, patch)
2014-03-08 13:48 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-03-06 21:43:13 PST
Created attachment 226082 [details] test case
zalan
Comment 2 2014-03-08 11:41:20 PST
Created attachment 226223 [details] Patch
Simon Fraser (smfr)
Comment 3 2014-03-08 11:43:18 PST
Comment on attachment 226223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226223&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:1612 > + // FIXME: composited background images will be fixed together with regular images. We don't support those yet.
zalan
Comment 4 2014-03-08 12:06:04 PST
Created attachment 226224 [details] Patch
zalan
Comment 5 2014-03-08 12:06:18 PST
Comment on attachment 226224 [details] Patch EWS testing.
zalan
Comment 6 2014-03-08 12:29:28 PST
Created attachment 226225 [details] Patch
zalan
Comment 7 2014-03-08 12:40:15 PST
Created attachment 226227 [details] Patch
Build Bot
Comment 8 2014-03-08 13:27:44 PST
Comment on attachment 226227 [details] Patch Attachment 226227 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5788178476695552 New failing tests: compositing/hidpi-simple-container-layer-on-device-pixel.html
Build Bot
Comment 9 2014-03-08 13:27:47 PST
Created attachment 226231 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 10 2014-03-08 13:45:36 PST
Comment on attachment 226227 [details] Patch Attachment 226227 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5964837997772800 New failing tests: compositing/hidpi-simple-container-layer-on-device-pixel.html
Build Bot
Comment 11 2014-03-08 13:45:40 PST
Created attachment 226232 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
zalan
Comment 12 2014-03-08 13:48:47 PST
Created attachment 226233 [details] Patch
WebKit Commit Bot
Comment 13 2014-03-08 16:08:13 PST
Comment on attachment 226233 [details] Patch Clearing flags on attachment: 226233 Committed r165341: <http://trac.webkit.org/changeset/165341>
WebKit Commit Bot
Comment 14 2014-03-08 16:08:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.