Bug 129852 - [OS X] Web Inspector: Allow Apps using JavaScriptCore to access "com.apple.webinspector" mach port
Summary: [OS X] Web Inspector: Allow Apps using JavaScriptCore to access "com.apple.we...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-06 17:30 PST by Joseph Pecoraro
Modified: 2014-03-06 20:16 PST (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (5.50 KB, patch)
2014-03-06 17:35 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-06 17:30:24 PST
For remote inspection to work, the application hosting a JSContext/WebView must be allowed to access the "com.apple.webinspector" mach port to connect to webinspectord. This is only needed for apps that use the JavaScriptCore framework, so we can have the framework extend the app's sandbox to allow access.
Comment 1 Joseph Pecoraro 2014-03-06 17:30:44 PST
<rdar://problem/16018541>
Comment 2 Joseph Pecoraro 2014-03-06 17:35:42 PST
Created attachment 226070 [details]
[PATCH] Proposed Fix

Should we avoid including framework.sh for earlier releases of OS X as well? It should be harmless there.
Comment 3 Geoffrey Garen 2014-03-06 19:44:27 PST
Comment on attachment 226070 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2014-03-06 20:16:09 PST
Comment on attachment 226070 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 226070

Committed r165245: <http://trac.webkit.org/changeset/165245>
Comment 5 WebKit Commit Bot 2014-03-06 20:16:11 PST
All reviewed patches have been landed.  Closing bug.