Bug 129842 – [CSS Shapes] polygon y-value calc() args serialize incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rebecca Hauck]

The attached tests file tests a polygon that has a calc() y-value:  polygon(10px calc(10in))

The inline style is serialized as:
polygon(nonzero, calc(10in) 0.000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000022278417114)

The correct serialization should be:
polygon(10px calc(10in)

The computed style is serializes as:

polygon(nonzero, 960px )

The correct serialization should be:

polygon(10px 960px) 

For both of these cases, the default fill-rule should also be omitted - that's logged as a separate bug:  https://bugs.webkit.org/show_bug.cgi?id=129840.

Note: I tested this with polygons with multiple vertices and it reproduces wherever the calc() y-value is on the arg list.

Note: This uses testharness.js and the relative path in the test assumes the test is run from LayoutTests/fast/shapes/parsing

[Rebecca Hauck]

Created attachment 226058 [details]
Test case for bug

[Zoltan Horvath]

Created attachment 228626 [details]
Patch

[Bem Jones-Bey]

Comment on attachment 228626 [details]
Patch

Global state is evil. Good catch.

r=me

[WebKit Commit Bot]

Comment on attachment 228626 [details]
Patch

Clearing flags on attachment: 228626

Committed r166813: <http://trac.webkit.org/changeset/166813>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.