Bug 129841 - [EME] Extend the lifetime of MediaKeySession.
Summary: [EME] Extend the lifetime of MediaKeySession.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
: 109644 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-03-06 16:02 PST by Jer Noble
Modified: 2014-04-25 10:27 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.71 KB, patch)
2014-03-06 16:09 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for Landing (7.28 KB, patch)
2014-03-14 12:12 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (8.05 KB, patch)
2014-03-14 12:15 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-03-06 16:02:33 PST 
[EME] Extend the lifetime of MediaKeySession.
Comment 1 Jer Noble 2014-03-06 16:09:20 PST 
Created attachment 226057 [details]
Patch
Comment 2 Eric Carlson 2014-03-06 19:48:46 PST 
Comment on attachment 226057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226057&action=review

Is it possible to add a test for this?

> Source/WebCore/Modules/encryptedmedia/MediaKeySession.h:74
> +    virtual bool hasPendingActivity() const override { return (!isClosed() && m_keys) || m_asyncEventQueue.hasPendingEvents(); }

Nit: I think "m_keys && !isClosed()" is slightly easier to understand.
Comment 3 Jer Noble 2014-03-14 12:12:11 PDT 
Created attachment 226748 [details]
Patch for Landing
Comment 4 Jer Noble 2014-03-14 12:15:42 PDT 
Created attachment 226749 [details]
Patch for landing

Added missing ChangeLog.
Comment 5 Jer Noble 2014-03-14 13:13:24 PDT 
Comment on attachment 226749 [details]
Patch for landing

sigh.  Clearing accidental r+ flag.
Comment 6 WebKit Commit Bot 2014-03-14 13:46:10 PDT 
Comment on attachment 226749 [details]
Patch for landing

Clearing flags on attachment: 226749

Committed r165643: <http://trac.webkit.org/changeset/165643>
Comment 7 WebKit Commit Bot 2014-03-14 13:46:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Jer Noble 2014-04-25 10:27:12 PDT 
*** Bug 109644 has been marked as a duplicate of this bug. ***