Bug 129837 - detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
Summary: detectFailures in run-jsc-stress-tests can report everything was ok if too ma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 15:21 PST by Mark Hahnenberg
Modified: 2014-03-06 18:12 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.41 KB, patch)
2014-03-06 15:35 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2014-03-06 17:24 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-06 15:21:38 PST 
This is due to the following line:

output = sshRead("cd #{$remoteDirectory}/#{$outputDir.basename}/.runner && (ls test_fail_* 2> /dev/null || true)")

ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.

The fix is to use find instead of ls like we do in shell-runner.sh.
Comment 1 Mark Hahnenberg 2014-03-06 15:35:19 PST 
Created attachment 226050 [details]
Patch
Comment 2 Mark Hahnenberg 2014-03-06 17:24:50 PST 
Created attachment 226067 [details]
Patch
Comment 3 WebKit Commit Bot 2014-03-06 18:12:54 PST 
Comment on attachment 226067 [details]
Patch

Clearing flags on attachment: 226067

Committed r165239: <http://trac.webkit.org/changeset/165239>
Comment 4 WebKit Commit Bot 2014-03-06 18:12:56 PST 
All reviewed patches have been landed.  Closing bug.