Bug 129833 - Missing include in JSConsole.cpp
Summary: Missing include in JSConsole.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 15:03 PST by Julien Brianceau
Modified: 2014-03-06 15:38 PST (History)
2 users (show)

See Also:

Attachments
Add missing include in JSConsole.cpp (908 bytes, patch)
2014-03-06 15:07 PST, Julien Brianceau 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2014-03-06 15:03:52 PST 
See buildbot: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/45406/steps/compile-webkit/logs/stdio

  CXXLD    Programs/jsc-3
./.libs/libjavascriptcoregtk-3.0.so: undefined reference to `JSC::JSValue::isGetterSetter() const'
./.libs/libjavascriptcoregtk-3.0.so: undefined reference to `JSC::JSCell::structure(JSC::VM&) const'
./.libs/libjavascriptcoregtk-3.0.so: undefined reference to `JSC::JSValue::encode(JSC::JSValue)'
./.libs/libjavascriptcoregtk-3.0.so: undefined reference to `JSC::JSValue::decode(long)'
collect2: error: ld returned 1 exit status
make[1]: *** [Programs/jsc-3] Error 1
Comment 1 Julien Brianceau 2014-03-06 15:07:06 PST 
Created attachment 226046 [details]
Add missing include in JSConsole.cpp
Comment 2 WebKit Commit Bot 2014-03-06 15:10:17 PST 
Attachment 226046 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSConsole.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Julien Brianceau 2014-03-06 15:15:10 PST 
Landed: http://trac.webkit.org/changeset/165221
Comment 4 Julien Brianceau 2014-03-06 15:26:48 PST 
... with style fixed: http://trac.webkit.org/changeset/165223