Bug 129819 - Let the user define the full address of the performance-site-server for uploading results
Summary: Let the user define the full address of the performance-site-server for uploa...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
Depends on:
Blocks: 77037
  Show dependency treegraph
Reported: 2014-03-06 13:00 PST by Zoltan Horvath
Modified: 2014-03-10 16:16 PDT (History)
3 users (show)

See Also:

Patch (4.83 KB, patch)
2014-03-06 13:02 PST, Zoltan Horvath
rniwa: review-
rniwa: commit-queue-
Details | Formatted Diff | Diff
Patch (5.24 KB, patch)
2014-03-06 14:04 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2014-03-06 13:00:08 PST
Currently perftestsrunner.py assumes that the server uses https protocol all the time.
That can be confusing. It's more straightforward, if you need to define explicitly the server's full address along with the protocol, when using this parameter.
This patch updates the behavior and the affected unit tests.
Comment 1 Zoltan Horvath 2014-03-06 13:02:31 PST
Created attachment 226029 [details]
Comment 2 Ryosuke Niwa 2014-03-06 13:26:29 PST
Comment on attachment 226029 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=226029&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:312
>      def _upload_json(self, test_results_server, json_path, host_path="/api/report", file_uploader=FileUploader):
> -        url = "https://%s%s" % (test_results_server, host_path)
> +        url = test_results_server + host_path

This would break bots on build.webkit.org. We need to support both inputs during the transition.
r- because of that.
Comment 3 Zoltan Horvath 2014-03-06 14:04:06 PST
Created attachment 226036 [details]

Added HTTPS as default protocol.
Comment 4 WebKit Commit Bot 2014-03-10 16:16:14 PDT
Comment on attachment 226036 [details]

Clearing flags on attachment: 226036

Committed r165413: <http://trac.webkit.org/changeset/165413>
Comment 5 WebKit Commit Bot 2014-03-10 16:16:17 PDT
All reviewed patches have been landed.  Closing bug.