Currently perftestsrunner.py assumes that the server uses https protocol all the time. That can be confusing. It's more straightforward, if you need to define explicitly the server's full address along with the protocol, when using this parameter. This patch updates the behavior and the affected unit tests.
Created attachment 226029 [details] Patch
Comment on attachment 226029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226029&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:312 > def _upload_json(self, test_results_server, json_path, host_path="/api/report", file_uploader=FileUploader): > - url = "https://%s%s" % (test_results_server, host_path) > + url = test_results_server + host_path This would break bots on build.webkit.org. We need to support both inputs during the transition. r- because of that.
Created attachment 226036 [details] Patch Added HTTPS as default protocol.
Comment on attachment 226036 [details] Patch Clearing flags on attachment: 226036 Committed r165413: <http://trac.webkit.org/changeset/165413>
All reviewed patches have been landed. Closing bug.