Bug 129802 – [GTK] Don't busy loop when the socket is full

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Giovanni Campagna]

[GTK] Don't busy loop when the socket is full

[Giovanni Campagna]

Created attachment 225992 [details]
Patch

[Philippe Normand]

Interesting patch!

Would you mind providing a ChangeLog? Tools/Scripts/prepare-ChangeLog can generate a template to fill out.

[Carlos Garcia Campos]

Comment on attachment 225992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225992&action=review

Thanks for the patch. This patch needs a ChangeLog, see http://www.webkit.org/coding/contributing.html.

> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:37
> +#include <poll.h>

Is this available in all UNIX platforms?

> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:535
> +            poll(&pollfd, 1, -1);
> +        }

Does this really work? Don't you need to continue the loop when poll returns?

[Giovanni Campagna]

(In reply to comment #3)
> (From update of attachment 225992 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225992&action=review
> 
> Thanks for the patch. This patch needs a ChangeLog, see http://www.webkit.org/coding/contributing.html.
> 
> > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:37
> > +#include <poll.h>
> 
> Is this available in all UNIX platforms?

Yes, it is part of the Single Unix Specification, see http://pubs.opengroup.org/onlinepubs/9699919799/toc.htm

[Giovanni Campagna]

Created attachment 226897 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 226897 [details]
Patch

Ok looks good. Thanks!

[WebKit Commit Bot]

Comment on attachment 226897 [details]
Patch

Clearing flags on attachment: 226897

Committed r165745: <http://trac.webkit.org/changeset/165745>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.