WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129794
Remove 'visibilitychange' attribute event listener from document
https://bugs.webkit.org/show_bug.cgi?id=129794
Summary
Remove 'visibilitychange' attribute event listener from document
Jinwoo Song
Reported
2014-03-06 02:35:30 PST
Remove the unused attribute event listener which is not defined in Page Visibility API spec, too.
http://www.w3.org/TR/page-visibility/#sec-document-interface
Attachments
Patch
(1.36 KB, patch)
2014-03-06 02:37 PST
,
Jinwoo Song
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jinwoo Song
Comment 1
2014-03-06 02:37:18 PST
Created
attachment 225974
[details]
Patch
Simon Fraser (smfr)
Comment 2
2014-03-06 18:15:24 PST
What is the web compat risk?
Jinwoo Song
Comment 3
2014-03-06 19:58:56 PST
(In reply to
comment #2
)
> What is the web compat risk?
As 'visibilitychange' was not declared in Document.idl, below code did not work. (I also tested in Mac Safari and EFL minibrowser.) <html onvisibilitychange="dostuff"> So there is no compatibility issue by this patch.
Simon Fraser (smfr)
Comment 4
2014-03-10 18:10:47 PDT
Comment on
attachment 225974
[details]
Patch So this breaks
WebKit Commit Bot
Comment 5
2014-03-10 19:20:48 PDT
Comment on
attachment 225974
[details]
Patch Clearing flags on attachment: 225974 Committed
r165423
: <
http://trac.webkit.org/changeset/165423
>
WebKit Commit Bot
Comment 6
2014-03-10 19:20:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug