Bug 129794 - Remove 'visibilitychange' attribute event listener from document
Summary: Remove 'visibilitychange' attribute event listener from document
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 02:35 PST by Jinwoo Song
Modified: 2014-03-10 19:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2014-03-06 02:37 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-03-06 02:35:30 PST 
Remove the unused attribute event listener which is not defined in Page Visibility API spec, too.
http://www.w3.org/TR/page-visibility/#sec-document-interface
Comment 1 Jinwoo Song 2014-03-06 02:37:18 PST 
Created attachment 225974 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-03-06 18:15:24 PST 
What is the web compat risk?
Comment 3 Jinwoo Song 2014-03-06 19:58:56 PST 
(In reply to comment #2)
> What is the web compat risk?

As 'visibilitychange' was not declared in Document.idl, below code did not work. (I also tested in Mac Safari and EFL minibrowser.)
<html onvisibilitychange="dostuff">

So there is no compatibility issue by this patch.
Comment 4 Simon Fraser (smfr) 2014-03-10 18:10:47 PDT 
Comment on attachment 225974 [details]
Patch

So this breaks
Comment 5 WebKit Commit Bot 2014-03-10 19:20:48 PDT 
Comment on attachment 225974 [details]
Patch

Clearing flags on attachment: 225974

Committed r165423: <http://trac.webkit.org/changeset/165423>
Comment 6 WebKit Commit Bot 2014-03-10 19:20:52 PDT 
All reviewed patches have been landed.  Closing bug.