Bug 129791 - Gradient offsets are off if compositing operator != source-over
Summary: Gradient offsets are off if compositing operator != source-over
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Andronikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 01:32 PST by Dirk Schulze
Modified: 2014-07-24 17:23 PDT (History)
10 users (show)

See Also:


Attachments
Example. Gradient should be in center of the canvas. (851 bytes, text/html)
2014-03-06 01:32 PST, Dirk Schulze
no flags Details
Patch (5.28 KB, patch)
2014-04-04 06:44 PDT, Dirk Schulze
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (492.06 KB, application/zip)
2014-04-04 08:05 PDT, Build Bot
no flags Details
Same Patch for EWS (5.28 KB, patch)
2014-04-04 08:10 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2014-03-06 01:32:41 PST
Created attachment 225966 [details]
Example. Gradient should be in center of the canvas.

The gradient offsets are off if compositing operator != source-over. It looks like the gradient space is not mapped to the canvas space correctly anymore.
Comment 1 Simon Fraser (smfr) 2014-03-06 10:29:38 PST
Broken in Safari 7. Did this ever work?
Comment 2 Dirk Schulze 2014-03-06 12:01:02 PST
(In reply to comment #1)
> Broken in Safari 7. Did this ever work?

I don't know. Just created this example.
Comment 3 Dirk Schulze 2014-04-04 06:44:17 PDT
Created attachment 228588 [details]
Patch
Comment 4 Build Bot 2014-04-04 08:05:37 PDT
Comment on attachment 228588 [details]
Patch

Attachment 228588 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5548938127998976

New failing tests:
transitions/cancel-transition.html
Comment 5 Build Bot 2014-04-04 08:05:42 PDT
Created attachment 228592 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Dirk Schulze 2014-04-04 08:09:07 PDT
I looked at the test case. It seems very unlikely that this Canvas only thing (even limited to the context of the ImageBuffer) influences the transition test.

This seems to be a false negative.
Comment 7 Dirk Schulze 2014-04-04 08:10:25 PDT
Created attachment 228593 [details]
Same Patch for EWS
Comment 8 Andreas Kling 2014-04-04 09:11:03 PDT
Comment on attachment 228593 [details]
Same Patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=228593&action=review

r=me

> LayoutTests/ChangeLog:13
> +        * fast/canvas/canvas-gradient-on-compositing.html: Added.
> +        * fast/canvas/script-tests/canvas-gradient-on-compositing.js: Added.

I'd do this as a single file instead of the old-style js/html split. NABD.
Comment 9 WebKit Commit Bot 2014-04-04 09:41:35 PDT
Comment on attachment 228593 [details]
Same Patch for EWS

Clearing flags on attachment: 228593

Committed r166785: <http://trac.webkit.org/changeset/166785>
Comment 10 WebKit Commit Bot 2014-04-04 09:41:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Nikos Andronikos 2014-07-24 17:23:06 PDT
*** Bug 132949 has been marked as a duplicate of this bug. ***