Bug 129782 - [GTK] [CMake] Clean up library linking
Summary: [GTK] [CMake] Clean up library linking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-05 23:14 PST by Martin Robinson
Modified: 2014-03-10 10:05 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.24 KB, patch)
2014-03-05 23:23 PST, Martin Robinson
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-03-05 23:14:08 PST
We currently wrap -Wl,--whole-archive around some libraries to avoid dropping symbols from convenience libraries (libtool used to take care of this for us). Instead of doing that manually we can write a macro to do it for all libraries in a list. This also exposes some situations in which we are over-linking, linking in the same convenience library twice, or compiling the same files into multiple convenience libraries. We should clean all of that up.
Comment 1 Martin Robinson 2014-03-05 23:23:52 PST
Created attachment 225955 [details]
Patch
Comment 2 Martin Robinson 2014-03-10 10:05:31 PDT
Committed r165378: <http://trac.webkit.org/changeset/165378>