Bug 129760 - Fix write barriers in Repatch.cpp for !ENABLE(DFG_JIT) platforms after r165128
Summary: Fix write barriers in Repatch.cpp for !ENABLE(DFG_JIT) platforms after r165128
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-05 15:03 PST by Mark Hahnenberg
Modified: 2014-03-06 11:55 PST (History)
1 user (show)

See Also:


Attachments
Patch (10.16 KB, patch)
2014-03-05 19:31 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-05 15:03:05 PST
r165128 disabled the write barrier fast path for inline caches on !ENABLE(DFG_JIT) platforms. The fix is to refactor the write barrier code into AssemblyHelpers and use that everywhere.
Comment 1 Mark Hahnenberg 2014-03-05 19:31:40 PST
Created attachment 225939 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-05 20:27:16 PST
Comment on attachment 225939 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-03-06 11:55:08 PST
Comment on attachment 225939 [details]
Patch

Clearing flags on attachment: 225939

Committed r165203: <http://trac.webkit.org/changeset/165203>
Comment 4 WebKit Commit Bot 2014-03-06 11:55:09 PST
All reviewed patches have been landed.  Closing bug.