Bug 129753 – ASSERT(newestManifest) fails in WebCore::ApplicationCacheGroup::didFinishLoadingManifest()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

For some reasons an app cache for a web site W may only be partially written to disk such that only a cached group entry is written. That is, no cached resources, including the manifest resource, are written to disk. Subsequently visiting W after loading the app cache from disk (say, by closing Safari and launching it again) will cause an assertion failure in WebCore::ApplicationCacheGroup::didFinishLoadingManifest() (ASSERT(newestManifest)) because the manifest resource for the latest completed app cache (newestManifest) is null.

[Daniel Bates]

<rdar://problem/12069835>

[Daniel Bates]

Created attachment 225919 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 225919 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225919&action=review

> Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1186
> +        LOG_ERROR("No manifest resource was in the cache");

I'd say: "Could not load application cache, because there was no manifest resource".

> Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1476
> +        if (!deleteCacheGroupRecord(manifestURL)) {
>              LOG_ERROR("Could not load cache group id, error \"%s\"", m_database.lastErrorMsg());

This log message doesn't look right now.

[Daniel Bates]

(In reply to comment #3)
> (From update of attachment 225919 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225919&action=review
> 
> > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1186
> > +        LOG_ERROR("No manifest resource was in the cache");
> 
> I'd say: "Could not load application cache, because there was no manifest resource".

Will change error message string to read:

"Could not load application cache because there was no manifest resource"

> 
> > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1476
> > +        if (!deleteCacheGroupRecord(manifestURL)) {
> >              LOG_ERROR("Could not load cache group id, error \"%s\"", m_database.lastErrorMsg());
> 
> This log message doesn't look right now.

Will change error message string to read:

"Could not delete cache group record, error \"%s\""

[Daniel Bates]

Committed r165145: <http://trac.webkit.org/changeset/165145>

[Daniel Bates]

*** Bug 129608 has been marked as a duplicate of this bug. ***