Bug 129739 - [CSS Shapes] large corner radius combined with 0 radius does not wrap properly
Summary: [CSS Shapes] large corner radius combined with 0 radius does not wrap properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on: 127982 129726
Blocks: 124173
  Show dependency tree / graph
 
Reported: 2014-03-05 07:30 PST by Bem Jones-Bey
Modified: 2014-04-08 15:26 PDT (History)
6 users (show)

See Also:

Attachments
inset example (522 bytes, text/html)
2014-03-05 07:30 PST, Bem Jones-Bey 		no flags Details
border-box example (950 bytes, text/html)
2014-03-05 08:23 PST, Bem Jones-Bey 		no flags Details
Patch (8.54 KB, patch)
2014-04-07 13:12 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2014-03-05 07:30:30 PST 
Created attachment 225881 [details]
inset example

If a corner radius larger than 50% of the length of the associated dimension (width or height) of the shape is combined with a corner radius that is 0, then wrapping doesn't happen properly to the resultant shape. This happens for both inset and box shapes. See the attached tests for examples.
Comment 1 Bem Jones-Bey 2014-03-05 08:23:42 PST 
Created attachment 225887 [details]
border-box example
Comment 2 Hans Muller 2014-04-07 13:12:26 PDT 
Created attachment 228753 [details]
Patch

Corrected special case handling for shape-outside border-box values with border-radius values that greater than or equal to the box's height.
Comment 3 Bem Jones-Bey 2014-04-08 14:57:05 PDT 
Comment on attachment 228753 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-04-08 15:26:30 PDT 
Comment on attachment 228753 [details]
Patch

Clearing flags on attachment: 228753

Committed r166966: <http://trac.webkit.org/changeset/166966>
Comment 5 WebKit Commit Bot 2014-04-08 15:26:33 PDT 
All reviewed patches have been landed.  Closing bug.