Bug 129709 - WinCairo needs to run layout tests
Summary: WinCairo needs to run layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 15:04 PST by Alex Christensen
Modified: 2014-03-04 22:18 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.81 KB, patch)
2014-03-04 15:12 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2014-03-04 20:49 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-03-04 15:04:10 PST
I'm almost all the way done with getting WinCairo to run layout tests.  I don't know how to get it to run "Tools/Scripts/webkit-build-directory --configuration --wincairo" instead of "Tools/Scripts/webkit-build-directory --configuration --debug --win".  When I put die() in isWinCairo() in webkitdirs.pm, I get this:

ScriptError raised: Failed to run "['perl', 'Tools/Scripts/webkit-build-directory', '--configuration', '--debug', '--win']" exit_code: 255 cwd: /webkit
Traceback (most recent call last):
  File "/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 80, in main
    run_details = run(port, options, args, stderr)
  File "/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 393, in run
    manager = Manager(port, options, printer)
  File "/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 88, in __init__
    self._results_directory = self._port.results_directory()
  File "/webkit/Tools/Scripts/webkitpy/port/base.py", line 776, in results_directory
    option_val = self.get_option('results_directory') or self.default_results_directory()
  File "/webkit/Tools/Scripts/webkitpy/port/base.py", line 787, in default_results_directory
    return self._build_path('layout-test-results')
  File "/webkit/Tools/Scripts/webkitpy/port/base.py", line 1116, in _build_path
    root_directory = self._config.build_directory(self.get_option('configuration'))
  File "/webkit/Tools/Scripts/webkitpy/port/config.py", line 84, in build_directory
    output = self._executive.run_command(args, cwd=self._webkit_finder.webkit_base(), return_stderr=False).rstrip()
  File "/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 452, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 370, in default_error_handler
    raise error

Where else do I need to put "wincairo" instead of just "win"?
Comment 1 Alex Christensen 2014-03-04 15:12:58 PST
Created attachment 225820 [details]
Patch
Comment 2 Alex Christensen 2014-03-04 15:55:35 PST
would defining my own _build_path function in win.py be a good solution?
Comment 3 Alex Christensen 2014-03-04 20:49:51 PST
Created attachment 225850 [details]
Patch
Comment 4 Alex Christensen 2014-03-04 20:52:12 PST
I can use the --root option to force the bot to use the correct build directory instead of navigating the python and adding wincairo options everywhere.  These changes are necessary for the program to even start, though.
Comment 5 WebKit Commit Bot 2014-03-04 22:18:45 PST
Comment on attachment 225850 [details]
Patch

Clearing flags on attachment: 225850

Committed r165097: <http://trac.webkit.org/changeset/165097>
Comment 6 WebKit Commit Bot 2014-03-04 22:18:47 PST
All reviewed patches have been landed.  Closing bug.