Bug 129705 - Allow iOS DumpRenderTree crashes to show application-specific information
Summary: Allow iOS DumpRenderTree crashes to show application-specific information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 14:22 PST by Simon Fraser (smfr)
Modified: 2014-03-04 14:43 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2014-03-04 14:22 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2014-03-04 14:25 PST, Simon Fraser (smfr) 		ddkilzer: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-03-04 14:22:04 PST 
Allow iOS DumpRenderTree crashes to show application-specific information
Comment 1 Simon Fraser (smfr) 2014-03-04 14:22:41 PST 
Created attachment 225813 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-04 14:24:20 PST 
Attachment 225813 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-03-04 14:25:32 PST 
Created attachment 225814 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2014-03-04 14:35:23 PST 
Comment on attachment 225814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225814&action=review

r=me if you fix the WebCore.exp.in file.

> Source/WebCore/WebCore.exp.in:2688
> +#if PLATFORM(MAC) || PLATFORM(IOS_SIMULATOR)
> +_wkSetCrashReportApplicationSpecificInformation
> +#endif

This needs re-sorting.  See Tools/Scripts/sort-export-file.
Comment 5 Simon Fraser (smfr) 2014-03-04 14:43:01 PST 
https://trac.webkit.org/r165080