[Mac][WK2] Videos do not have access to session cookies
Created attachment 225792 [details] Patch
Comment on attachment 225792 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225792&action=review > Source/WebKit2/Shared/mac/CookieStorageShim.mm:36 > +#include <Foundation/NSURLSession.h> This needs to be conditionally included. > Source/WebKit2/Shared/mac/CookieStorageShim.mm:99 > +- (void)_getCookieHeadersForTask:(NSURLSessionTask*)task completionHandler:(void (^)(CFDictionaryRef))completionHandler Can completionHandler be NULL?
Created attachment 226315 [details] Patch for landing
Created attachment 228221 [details] Patch
Comment on attachment 228221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228221&action=review > Source/WebKit2/Shared/mac/CookieStorageShim.mm:116 > + dispatch_async(dispatch_get_main_queue(), ^{ > + completionHandler(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL(nullptr, (CFURLRef)[[task currentRequest] URL])); Can completionHandler be NULL?
Created attachment 228309 [details] Patch for landing
Created attachment 228615 [details] Patch for landing
Comment on attachment 228221 [details] Patch Obsoleting an old version of the patch.
Comment on attachment 228615 [details] Patch for landing Clearing flags on attachment: 228615 Committed r166812: <http://trac.webkit.org/changeset/166812>
All reviewed patches have been landed. Closing bug.
(In reply to comment #10) > All reviewed patches have been landed. Closing bug. Looks like it this broke 32-bit builds on Mavericks. CompileC CookieStorageShim.o OpenSource/Source/WebKit2/Shared/mac/CookieStorageShim.mm:54:35: error: expected a type - (void)_getCookieHeadersForTask:(NSURLSessionTask*)task completionHandler:(void (^)(CFDictionaryRef))completionHandler; ^ OpenSource/Source/WebKit2/Shared/mac/CookieStorageShim.mm:117:35: error: expected a type - (void)_getCookieHeadersForTask:(NSURLSessionTask*)task completionHandler:(void (^)(CFDictionaryRef))completionHandler ^ 2 errors generated. I'm going to roll it out, because if that is the case then this bug probably needs to be addressed differently / tested on 32 bit.
Rolled out in: <http://trac.webkit.org/changeset/166819>
(In reply to comment #12) > Rolled out in: <http://trac.webkit.org/changeset/166819> Just needed a forward declaration of NSURLSessionTask.
Committed r166940: <http://trac.webkit.org/changeset/166940>