Bug 129673 - Micro-optimize Strings in JS bindings.
Summary: Micro-optimize Strings in JS bindings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 01:46 PST by Andreas Kling
Modified: 2014-03-04 08:59 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.68 KB, patch)
2014-03-04 01:49 PST, Andreas Kling 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-04 01:46:07 PST 
Micro-optimize Strings in JS bindings.
Comment 1 Andreas Kling 2014-03-04 01:49:40 PST 
Created attachment 225762 [details]
Patch
Comment 2 Andreas Kling 2014-03-04 01:57:43 PST 
Comment on attachment 225762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review

> Source/JavaScriptCore/runtime/JSString.h:419
> +        // Should have picked a global empty or single-character string already.

s/global/VM-global/
Comment 3 Ryosuke Niwa 2014-03-04 02:05:08 PST 
Comment on attachment 225762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review

> Source/WebCore/bindings/js/JSDOMBinding.h:597
> +    return JSC::jsStringWithWeakOwner(vm, *s.impl());

Why don't we use *stringImpl instead?
Comment 4 Andreas Kling 2014-03-04 08:59:45 PST 
Committed r165054: <http://trac.webkit.org/changeset/165054>