RESOLVED FIXED129673
Micro-optimize Strings in JS bindings. 
https://bugs.webkit.org/show_bug.cgi?id=129673
Summary Micro-optimize Strings in JS bindings.
Andreas Kling
Reported 2014-03-04 01:46:07 PST
Micro-optimize Strings in JS bindings.
Attachments
Patch (4.68 KB, patch)
2014-03-04 01:49 PST, Andreas Kling 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-03-04 01:49:40 PST
Created attachment 225762 [details] Patch
Andreas Kling
Comment 2 2014-03-04 01:57:43 PST
Comment on attachment 225762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review > Source/JavaScriptCore/runtime/JSString.h:419 > + // Should have picked a global empty or single-character string already. s/global/VM-global/
Ryosuke Niwa
Comment 3 2014-03-04 02:05:08 PST
Comment on attachment 225762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review > Source/WebCore/bindings/js/JSDOMBinding.h:597 > + return JSC::jsStringWithWeakOwner(vm, *s.impl()); Why don't we use *stringImpl instead?
Andreas Kling
Comment 4 2014-03-04 08:59:45 PST
Committed r165054: <http://trac.webkit.org/changeset/165054>
Note You need to log in before you can comment on or make changes to this bug.