Bug 129671 – inSynchronizationOfLazyAttribute is making setAttributeInternal incomprehensible

• Status: RESOLVED
• Resolution: WONTFIX
• Component: DOM

[Ryosuke Niwa]

inSynchronizationOfLazyAttribute is evaluated 4 times in various conditions even though
all can just call ensureUniqueElementData().attributeAt(index).setValue(newValue) and exit early when it's true.

Just do that so that the rest of code is more readable.

[Ryosuke Niwa]

Created attachment 225764 [details]
Cleanup

[Andreas Kling]

Comment on attachment 225764 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=225764&action=review

> Source/WebCore/dom/Element.cpp:1032
> +    if (UNLIKELY(inSynchronizationOfLazyAttribute)) {
> +        ensureUniqueElementData().attributeAt(index).setValue(newValue);
> +        return;
> +    }

I think you have a bug here. If there is an Attr node, you will no longer reset its text children.

[Ryosuke Niwa]

Comment on attachment 225764 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=225764&action=review

>> Source/WebCore/dom/Element.cpp:1032
>> +    }
> 
> I think you have a bug here. If there is an Attr node, you will no longer reset its text children.

It comes from http://trac.webkit.org/changeset/139100. I can add a comment if you'd like.

[Ryosuke Niwa]

Comment on attachment 225764 [details]
Cleanup

Too old.