Bug 129654 - [GTK][WK1] Add load-error-with-tls-errors signal to WebKitWebView
Summary: [GTK][WK1] Add load-error-with-tls-errors signal to WebKitWebView
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 129653
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-03 20:04 PST by Ben Boeckel
Modified: 2014-06-04 00:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (26 bytes, patch)
2014-03-03 20:14 PST, Ben Boeckel 		no flags Details | Formatted Diff | Diff
Add-load-error-with-tls-errors-to-WebKit1 (15.52 KB, patch)
2014-03-04 22:40 PST, Ben Boeckel 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Boeckel 2014-03-03 20:04:48 PST 
Matches the WK2 signal. This is necessary because the WebKitWebFrame's WebKitNetworkResponse has a NULL SoupMessage (where I had expected to find the actual error).
Comment 1 Ben Boeckel 2014-03-03 20:14:07 PST 
Created attachment 225733 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-03 20:36:20 PST 
Attachment 225733 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2014-03-04 08:27:17 PST 
During what signal is the SoupMessage null?
Comment 4 Ben Boeckel 2014-03-04 08:33:41 PST 
"load-error". When asking for it, the WebKitNetworkResponse is constructed with the "uri" property rather than the "message" property in kitNew.
Comment 5 Ben Boeckel 2014-03-04 22:40:50 PST 
Created attachment 225859 [details]
Add-load-error-with-tls-errors-to-WebKit1

Actual patch rather than the empty file uploaded by "Tools/Scripts/webkit-patch attach-to-bug -g HEAD -m Patch 129654 WK1-TLS-error-signal.patch".
Comment 6 Ben Boeckel 2014-03-05 15:00:48 PST 
I'm guessing CMake needs to be updated for the new files as well (btw, is there a timeline for using CMake as the official build system?).
Comment 7 Ben Boeckel 2014-03-05 21:07:18 PST 
Heh, (In reply to comment #6)
> (btw, is there a timeline for using CMake as the official build system?).

...and perfect timing with the latest ML post.
Comment 8 Martin Robinson 2014-04-08 17:47:12 PDT 
WebKit1GTK+ has been removed.
Comment 9 Csaba Osztrogonác 2014-06-04 00:50:56 PDT 
Comment on attachment 225859 [details]
Add-load-error-with-tls-errors-to-WebKit1

Cleared review? from attachment 225859 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).