Bug 129654 – [GTK][WK1] Add load-error-with-tls-errors signal to WebKitWebView

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKitGTK

[Ben Boeckel]

Matches the WK2 signal. This is necessary because the WebKitWebFrame's WebKitNetworkResponse has a NULL SoupMessage (where I had expected to find the actual error).

[Ben Boeckel]

Created attachment 225733 [details]
Patch

[WebKit Commit Bot]

Attachment 225733 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

During what signal is the SoupMessage null?

[Ben Boeckel]

"load-error". When asking for it, the WebKitNetworkResponse is constructed with the "uri" property rather than the "message" property in kitNew.

[Ben Boeckel]

Created attachment 225859 [details]
Add-load-error-with-tls-errors-to-WebKit1

Actual patch rather than the empty file uploaded by "Tools/Scripts/webkit-patch attach-to-bug -g HEAD -m Patch 129654 WK1-TLS-error-signal.patch".

[Ben Boeckel]

I'm guessing CMake needs to be updated for the new files as well (btw, is there a timeline for using CMake as the official build system?).

[Ben Boeckel]

Heh, (In reply to comment #6)
> (btw, is there a timeline for using CMake as the official build system?).

...and perfect timing with the latest ML post.

[Martin Robinson]

WebKit1GTK+ has been removed.

[Csaba Osztrogonác]

Comment on attachment 225859 [details]
Add-load-error-with-tls-errors-to-WebKit1

Cleared review? from attachment 225859 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).