Bug 129650 - Merge API shims and JSLock
Summary: Merge API shims and JSLock
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
Depends on:
Reported: 2014-03-03 19:18 PST by Mark Hahnenberg
Modified: 2014-03-04 13:32 PST (History)
8 users (show)

See Also:

Patch (78.65 KB, patch)
2014-03-04 10:41 PST, Mark Hahnenberg
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-03 19:18:35 PST
There can be only one!
Comment 1 Mark Hahnenberg 2014-03-04 10:41:47 PST
Created attachment 225790 [details]
Comment 2 WebKit Commit Bot 2014-03-04 10:42:57 PST
Attachment 225790 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/runtime/JSLock.cpp:260:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSLock.h:52:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 33 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2014-03-04 11:10:33 PST
Comment on attachment 225790 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=225790&action=review

Nice.  r=me with minor fix.

> Source/JavaScriptCore/runtime/JSLock.cpp:142
> +    m_entryIdentifierTable = wtfThreadData().setCurrentIdentifierTable(m_vm->identifierTable);

"wtfThreadData()" ==> "threadData".
Comment 4 Mark Hahnenberg 2014-03-04 13:32:39 PST
Committed r165074: <http://trac.webkit.org/changeset/165074>