Bug 129631 - Web Inspector: Avoid too early deref caused by RemoteInspectorXPCConnection::close
Summary: Web Inspector: Avoid too early deref caused by RemoteInspectorXPCConnection::...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-03 15:39 PST by Joseph Pecoraro
Modified: 2014-03-03 22:52 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (7.01 KB, patch)
2014-03-03 16:50 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-03 15:39:46 PST 
Overall, the multithreaded aspects of RemoteInspectorXPCConnection are too complicated. This should be simplified in someway. For now, address a couple possible issues:

    - multithreaded access to m_client (close(), and XPC event handler)
    - deref too early in close(), if close() is called, we will receive another XPC event (XPC_ERROR)
      - so deref after we receive the XPC_ERROR event
Comment 1 Radar WebKit Bug Importer 2014-03-03 15:40:28 PST 
<rdar://problem/16216505>
Comment 2 Joseph Pecoraro 2014-03-03 16:50:15 PST 
Created attachment 225713 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-03-03 22:52:20 PST 
Comment on attachment 225713 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 225713

Committed r165040: <http://trac.webkit.org/changeset/165040>
Comment 4 WebKit Commit Bot 2014-03-03 22:52:22 PST 
All reviewed patches have been landed.  Closing bug.