Bug 129624 - [CSS Shapes] Add performance tests for Shapes with Regions
Summary: [CSS Shapes] Add performance tests for Shapes with Regions
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
Depends on:
Blocks: 128188
  Show dependency treegraph
Reported: 2014-03-03 14:50 PST by Zoltan Horvath
Modified: 2014-03-28 11:18 PDT (History)
7 users (show)

See Also:

Patch (25.03 KB, patch)
2014-03-03 14:54 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff
screenshot (940.17 KB, image/png)
2014-03-05 22:47 PST, Zoltan Horvath
no flags Details
Patch (25.03 KB, patch)
2014-03-10 15:21 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch (25.03 KB, patch)
2014-03-10 15:35 PDT, Zoltan Horvath
rniwa: review+
Details | Formatted Diff | Diff
Patch for landing (25.09 KB, patch)
2014-03-28 10:41 PDT, Zoltan Horvath
zoltan: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (25.09 KB, patch)
2014-03-28 10:42 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2014-03-03 14:50:31 PST
This tests introduces a real-life like page, which contains different types of shapes within shape-outsides. The content flows through regions, which use media queries.
The performance test loads the actual Shapes-Regions test case into iframes with different page sizes (thus the layout triggers the media queries as well)., and measures its load time.
Comment 1 Zoltan Horvath 2014-03-03 14:54:05 PST
Created attachment 225692 [details]
Comment 2 Ryosuke Niwa 2014-03-05 22:31:28 PST
Could you attach the page here so that we can see what it looks like?
Comment 3 Zoltan Horvath 2014-03-05 22:47:40 PST
Created attachment 225954 [details]

The content flows into the region-flow 3 times, the last couple of regions are simple window size boxes. The first 3 columns adopts (reduces to 2 and 1 column) to the actual page size with the help of media queries.  Each shape is defined by a different way. The test showed up a bug float flowing bug with regions, I reported it separately.
If you like this for testing, I'm gonna introduce the same page region-/shapeless versions under Shape, so it can run locally if someone wants to test them.
Comment 4 Ryosuke Niwa 2014-03-10 14:49:28 PDT
Comment on attachment 225692 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=225692&action=review

> PerformanceTests/Layout/RegionsShapes.html:15
> +    iframe.style.width = '100%';

I don't think we want to use 100% because then the performance will be dependent on how wide your window is.
Comment 5 Zoltan Horvath 2014-03-10 15:21:37 PDT
Created attachment 226339 [details]

I modified it to use fix size.
Comment 6 Zoltan Horvath 2014-03-10 15:35:50 PDT
Created attachment 226342 [details]

Modified the size to keep good friendship with DumpRenderTree's default width.
Comment 7 Zoltan Horvath 2014-03-27 23:52:34 PDT
Comment 8 Ryosuke Niwa 2014-03-28 09:55:55 PDT
Comment on attachment 226342 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=226342&action=review

> PerformanceTests/Layout/RegionsShapes.html:15
> +    iframe.style.width = '800px';

800px wouldn't work unless we set padding/margin on html/body to 0.
Comment 9 Zoltan Horvath 2014-03-28 10:41:47 PDT
Created attachment 228063 [details]
Patch for landing
Comment 10 Zoltan Horvath 2014-03-28 10:42:47 PDT
Created attachment 228064 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2014-03-28 11:18:37 PDT
Comment on attachment 228064 [details]
Patch for landing

Clearing flags on attachment: 228064

Committed r166416: <http://trac.webkit.org/changeset/166416>
Comment 12 WebKit Commit Bot 2014-03-28 11:18:41 PDT
All reviewed patches have been landed.  Closing bug.