Bug 129614 - filter-build-webkit should not strip .o
Summary: filter-build-webkit should not strip .o
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-03 11:51 PST by Joseph Pecoraro
Modified: 2014-03-06 18:10 PST (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.66 KB, patch)
2014-03-03 11:53 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-03 11:51:46 PST 
When there is a build error and builds do not stop on the first error then it is very easy to jump from the end "Foo.o failed to compile" up to the error messages by selecting and searching for "Foo.o". Stripping the .o's in the output makes the jump harder.

Do others agree?
Comment 1 Joseph Pecoraro 2014-03-03 11:53:45 PST 
Created attachment 225677 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-03-06 18:10:40 PST 
Comment on attachment 225677 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 225677

Committed r165238: <http://trac.webkit.org/changeset/165238>
Comment 3 WebKit Commit Bot 2014-03-06 18:10:45 PST 
All reviewed patches have been landed.  Closing bug.