Bug 129611 - ScriptExecutionContext::vm() should return a reference.
Summary: ScriptExecutionContext::vm() should return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-03 10:20 PST by Andreas Kling
Modified: 2014-03-16 13:21 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.61 KB, patch)
2014-03-03 10:20 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (7.88 KB, patch)
2014-03-03 10:30 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (8.51 KB, patch)
2014-03-03 11:07 PST, Andreas Kling 		ggaren: review+
Details | Formatted Diff | Diff
Patch (10.10 KB, patch)
2014-03-16 12:28 PDT, Andreas Kling 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Geoffrey (10.10 KB, patch)
2014-03-16 12:42 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-03 10:20:01 PST 
ScriptExecutionContext::vm() should return a reference.
Comment 1 Andreas Kling 2014-03-03 10:20:25 PST 
Created attachment 225666 [details]
Patch
Comment 2 Andreas Kling 2014-03-03 10:30:50 PST 
Created attachment 225668 [details]
Patch
Comment 3 Andreas Kling 2014-03-03 11:07:57 PST 
Created attachment 225673 [details]
Patch
Comment 4 Geoffrey Garen 2014-03-03 13:36:27 PST 
Comment on attachment 225673 [details]
Patch 

r=me

Please fix Windows build.
Comment 5 Andreas Kling 2014-03-16 12:28:46 PDT 
Created attachment 226851 [details]
Patch
Comment 6 WebKit Commit Bot 2014-03-16 12:29:49 PDT 
Comment on attachment 226851 [details]
Patch

Rejecting attachment 226851 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226851, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Geoff Garen found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6737959357251584
Comment 7 Andreas Kling 2014-03-16 12:42:41 PDT 
Created attachment 226852 [details]
Geoffrey
Comment 8 WebKit Commit Bot 2014-03-16 13:21:34 PDT 
Comment on attachment 226852 [details]
Geoffrey

Clearing flags on attachment: 226852

Committed r165710: <http://trac.webkit.org/changeset/165710>
Comment 9 WebKit Commit Bot 2014-03-16 13:21:39 PDT 
All reviewed patches have been landed.  Closing bug.