WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129600
[WebKit2][iOS] PDF
https://bugs.webkit.org/show_bug.cgi?id=129600
Summary
[WebKit2][iOS] PDF
Tim Horton
Reported
2014-03-02 23:13:27 PST
<
rdar://problem/15260216
>
Attachments
preliminary
(56.33 KB, patch)
2014-03-02 23:16 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
patch
(55.81 KB, patch)
2014-03-02 23:36 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
still preliminary
(56.03 KB, patch)
2014-03-02 23:38 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
patch
(73.90 KB, patch)
2014-03-06 01:03 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
split patch
(19.37 KB, patch)
2014-03-07 03:01 PST
,
Tim Horton
andersca
: review+
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2014-03-02 23:16:41 PST
Created
attachment 225633
[details]
preliminary
Tim Horton
Comment 2
2014-03-02 23:36:52 PST
Created
attachment 225634
[details]
patch
Tim Horton
Comment 3
2014-03-02 23:38:00 PST
Created
attachment 225635
[details]
still preliminary
Tim Horton
Comment 4
2014-03-05 11:35:55 PST
Comment on
attachment 225635
[details]
still preliminary View in context:
https://bugs.webkit.org/attachment.cgi?id=225635&action=review
> Source/WebKit2/Configurations/WebKit2.xcconfig:33 > +FRAMEWORK_AND_LIBRARY_LDFLAGS_iphonesimulator = -lobjc -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework GraphicsServices -framework ImageIO -framework UIKit -framework WebKit -lMobileGestalt -lassertion_extension -framework CorePDF;
alphabetize
> Source/WebKit2/UIProcess/Cocoa/CustomRepresentationManager.h:46 > +
another header
> Source/WebKit2/UIProcess/Cocoa/CustomRepresentationManager.h:47 > +- (instancetype)initWithFrame:(CGRect)frame;
nope
> Source/WebKit2/UIProcess/Cocoa/CustomRepresentationManager.h:49 > +- (void)setData:(CFDataRef)data;
web_setCustomRepresentationData or setWebCustomRepresentationData or something like that (and Dan says it should be NSData instead)
> Source/WebKit2/UIProcess/Cocoa/CustomRepresentationManager.h:52 > +- (void)setContentInset:(UIEdgeInsets)insets;
don't need this if we re-use the scrollview
> Source/WebKit2/UIProcess/Cocoa/CustomRepresentationManager.h:62 > +struct CustomRepresentation { > + Class representationClass; > + String mimeType; > +};
move into the class
Tim Horton
Comment 5
2014-03-06 01:03:23 PST
Created
attachment 225964
[details]
patch I just noticed that we need to save and restore a few more scrollview properties (minimum and maximum magnification at least) in the case where you are navigating back to a page that's in the page cache (but we can just do it always, I think); I'll fix that up tomorrow.
Tim Horton
Comment 6
2014-03-06 11:08:08 PST
Splitting this up.
Tim Horton
Comment 7
2014-03-07 03:01:27 PST
Created
attachment 226106
[details]
split patch This now depends on
https://bugs.webkit.org/show_bug.cgi?id=129809
so it won't apply yet.
Anders Carlsson
Comment 8
2014-03-07 15:56:48 PST
Comment on
attachment 226106
[details]
split patch View in context:
https://bugs.webkit.org/attachment.cgi?id=226106&action=review
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:46 > +@interface WKPDFView () { > + RetainPtr<UIPDFDocument> _pdfDocument; > + Vector<UIPDFPageView*> _pageViews; > + CGSize _minimumSize; > + UIScrollView *_scrollView; > +} > +@end
Just move these to the @implementation section instead.
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:55 > + [self setBackgroundColor:[UIColor grayColor]];
self.backgroundColor =
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:79 > + [[pageView contentLayer] setContentsScale:self.window.screen.scale];
pageView.contentLayer.contentsScale =
Tim Horton
Comment 9
2014-03-07 22:38:36 PST
http://trac.webkit.org/changeset/165327
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug