Bug 129595 - Remove non-working optimization that was attempted on iOS only
Summary: Remove non-working optimization that was attempted on iOS only
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad All
: P2 Normal
Assignee: Darin Adler
Depends on:
Reported: 2014-03-02 17:59 PST by Darin Adler
Modified: 2014-03-07 09:45 PST (History)
8 users (show)

See Also:

Patch (7.03 KB, patch)
2014-03-02 18:02 PST, Darin Adler
sam: review+
darin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-03-02 17:59:22 PST
Remove non-working optimization that was attempted on iOS-only
Comment 1 Darin Adler 2014-03-02 18:02:24 PST
Created attachment 225621 [details]
Comment 2 Darin Adler 2014-03-02 18:03:16 PST
I’m happy to consider the other version, fixing the optimization and enabling it for all platforms, if you’d prefer.
Comment 3 Darin Adler 2014-03-02 18:11:14 PST
Comment on attachment 225621 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=225621&action=review

> Source/WebCore/bindings/js/JSDOMWindowBase.cpp:215

I reversed this #if, but I forgot to add the "!".
Comment 4 Darin Adler 2014-03-04 09:01:31 PST
Landed this a while ago. Not sure the revision number.
Comment 5 Andreas Kling 2014-03-04 10:56:56 PST
Not landed just yet.
Comment 6 Joseph Pecoraro 2014-03-04 11:13:52 PST
Comment 7 Darin Adler 2014-03-07 09:45:19 PST
Committed r165269: <http://trac.webkit.org/changeset/165269>