WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129595
Remove non-working optimization that was attempted on iOS only
https://bugs.webkit.org/show_bug.cgi?id=129595
Summary
Remove non-working optimization that was attempted on iOS only
Darin Adler
Reported
2014-03-02 17:59:22 PST
Remove non-working optimization that was attempted on iOS-only
Attachments
Patch
(7.03 KB, patch)
2014-03-02 18:02 PST
,
Darin Adler
sam
: review+
darin
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2014-03-02 18:02:24 PST
Created
attachment 225621
[details]
Patch
Darin Adler
Comment 2
2014-03-02 18:03:16 PST
I’m happy to consider the other version, fixing the optimization and enabling it for all platforms, if you’d prefer.
Darin Adler
Comment 3
2014-03-02 18:11:14 PST
Comment on
attachment 225621
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=225621&action=review
> Source/WebCore/bindings/js/JSDOMWindowBase.cpp:215 > #if PLATFORM(IOS)
I reversed this #if, but I forgot to add the "!".
Darin Adler
Comment 4
2014-03-04 09:01:31 PST
Landed this a while ago. Not sure the revision number.
Andreas Kling
Comment 5
2014-03-04 10:56:56 PST
Not landed just yet.
Joseph Pecoraro
Comment 6
2014-03-04 11:13:52 PST
<
rdar://problem/15798825
>
Darin Adler
Comment 7
2014-03-07 09:45:19 PST
Committed
r165269
: <
http://trac.webkit.org/changeset/165269
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug