Bug 129584 - CodeBlock::hasDebuggerRequests() should returning a bool instead of an int
Summary: CodeBlock::hasDebuggerRequests() should returning a bool instead of an int
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-02 15:01 PST by Mark Lam
Modified: 2014-03-02 15:57 PST (History)
7 users (show)

See Also:


Attachments
the patch. (1.24 KB, patch)
2014-03-02 15:03 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-03-02 15:01:31 PST
Trivial change.  Patch coming.
Comment 1 Mark Lam 2014-03-02 15:03:46 PST
Created attachment 225613 [details]
the patch.
Comment 2 Darin Adler 2014-03-02 15:26:22 PST
Comment on attachment 225613 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=225613&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.h:880
> +    bool hasDebuggerRequests() const { return !!m_debuggerRequests; }

By the way, there is no need for the !! here. That was only needed in compilers that lacked bool support, but we don’t compile WebKit with those kinds of old compilers.
Comment 3 WebKit Commit Bot 2014-03-02 15:57:29 PST
Comment on attachment 225613 [details]
the patch.

Clearing flags on attachment: 225613

Committed r164954: <http://trac.webkit.org/changeset/164954>
Comment 4 WebKit Commit Bot 2014-03-02 15:57:31 PST
All reviewed patches have been landed.  Closing bug.