Bug 129569 - Make Length functions take viewport size instead of RenderView*
Summary: Make Length functions take viewport size instead of RenderView*
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-01 19:15 PST by zalan
Modified: 2014-05-21 15:12 PDT (History)
23 users (show)

See Also:

Attachments
Patch (70.80 KB, patch)
2014-03-01 19:32 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (71.73 KB, patch)
2014-03-01 20:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (71.94 KB, patch)
2014-03-01 20:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-03-01 19:15:06 PST 
int minimumIntValueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0, bool roundPercentages = false);
int intValueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0, bool roundPercentages = false);
LayoutUnit minimumValueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0, bool roundPercentages = false);
LayoutUnit valueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0, bool roundPercentages = false);
float floatValueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0);
float floatValueForLength(const Length&, float maximumValue, RenderView* = 0);
Comment 1 zalan 2014-03-01 19:32:22 PST 
Created attachment 225581 [details]
Patch
Comment 2 zalan 2014-03-01 20:12:39 PST 
Created attachment 225585 [details]
Patch
Comment 3 zalan 2014-03-01 20:12:58 PST 
Comment on attachment 225585 [details]
Patch

EWS testing
Comment 4 zalan 2014-03-01 20:57:46 PST 
Created attachment 225588 [details]
Patch
Comment 5 zalan 2014-03-01 20:57:57 PST 
Comment on attachment 225588 [details]
Patch

EWS
Comment 6 zalan 2014-03-08 16:26:47 PST 
viewportSize() call can still be a bit expensive on some platforms. WebKit is not ready for this change yet.