Bug 129557 – Subpixel rendering: Make GraphicsLayer::fillRect FloatRoundedRect based and cleanup dependencies.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan baradlay]

Merge FloatRect + Radii parameters to FloatRoundedRect.

[alan baradlay]

Created attachment 225568 [details]
Patch

[alan baradlay]

Created attachment 225583 [details]
Patch

[alan baradlay]

Comment on attachment 225583 [details]
Patch

EWS testing

[alan baradlay]

Created attachment 225587 [details]
Patch

[alan baradlay]

Comment on attachment 225587 [details]
Patch

EWS

[alan baradlay]

Created attachment 225589 [details]
Patch

[alan baradlay]

Comment on attachment 225589 [details]
Patch

EWS win testing

[alan baradlay]

Created attachment 225629 [details]
Patch

[alan baradlay]

Comment on attachment 225629 [details]
Patch

updated patch. ews.

[alan baradlay]

Created attachment 225658 [details]
Patch

[alan baradlay]

Comment on attachment 225658 [details]
Patch

EWS win.

[alan baradlay]

Created attachment 225682 [details]
Patch

[alan baradlay]

Comment on attachment 225682 [details]
Patch

EWS win.

[Simon Fraser (smfr)]

Comment on attachment 225682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225682&action=review

> Source/WebCore/platform/graphics/FloatRoundedRect.cpp:151
> +    && m_radii.bottomLeft().width() + m_radii.bottomRight().width() <= m_rect.width()
> +    && m_radii.topLeft().height() + m_radii.bottomLeft().height() <= m_rect.height()
> +    && m_radii.topRight().height() + m_radii.bottomRight().height() <= m_rect.height();

Indent these lines.

> Source/WebCore/platform/graphics/Path.cpp:135
> +    if (rect.width() < radii.topLeft().width() + radii.topRight().width()
> +        || rect.width() < radii.bottomLeft().width() + radii.bottomRight().width()
> +        || rect.height() < radii.topLeft().height() + radii.bottomLeft().height()
> +        || rect.height() < radii.topRight().height() + radii.bottomRight().height()) {
>          // If all the radii cannot be accommodated, return a rect.

Is this the same logic as isRenderable?

[alan baradlay]

Created attachment 225777 [details]
Patch

[alan baradlay]

Comment on attachment 225777 [details]
Patch

EWS testing before commit.

[alan baradlay]

(In reply to comment #14)
> (From update of attachment 225682 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225682&action=review
> 
> > Source/WebCore/platform/graphics/FloatRoundedRect.cpp:151
> > +    && m_radii.bottomLeft().width() + m_radii.bottomRight().width() <= m_rect.width()
> > +    && m_radii.topLeft().height() + m_radii.bottomLeft().height() <= m_rect.height()
> > +    && m_radii.topRight().height() + m_radii.bottomRight().height() <= m_rect.height();
> 
> Indent these lines.
Done.

> 
> > Source/WebCore/platform/graphics/Path.cpp:135
> > +    if (rect.width() < radii.topLeft().width() + radii.topRight().width()
> > +        || rect.width() < radii.bottomLeft().width() + radii.bottomRight().width()
> > +        || rect.height() < radii.topLeft().height() + radii.bottomLeft().height()
> > +        || rect.height() < radii.topRight().height() + radii.bottomRight().height()) {
> >          // If all the radii cannot be accommodated, return a rect.
> 
> Is this the same logic as isRenderable?
Yes. Fixed.

[WebKit Commit Bot]

Comment on attachment 225777 [details]
Patch

Clearing flags on attachment: 225777

Committed r165055: <http://trac.webkit.org/changeset/165055>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.