RESOLVED FIXED 129548
[Mac] Crash in MediaPlayer::rateChanged() 
https://bugs.webkit.org/show_bug.cgi?id=129548
Summary [Mac] Crash in MediaPlayer::rateChanged()
Jer Noble
Reported 2014-03-01 09:50:27 PST
[Mac] Crash in MediaPlayer::rateChanged()
Attachments
Patch (9.30 KB, patch)
2014-03-01 09:59 PST, Jer Noble 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-03-01 09:59:54 PST
Created attachment 225555 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-01 10:02:53 PST
Attachment 225555 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:135: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2014-03-01 16:00:52 PST
Comment on attachment 225555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225555&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2142 > + if (!weakThis) > + return; > + function(); This needs a comment. The technique of checking weakThis because we know that’s a precondition for function still being OK to call is subtle. Not the good kind of subtle for programming.
Jer Noble
Comment 4 2014-03-03 12:43:22 PST
Committed r165000: <http://trac.webkit.org/changeset/165000>
Note You need to log in before you can comment on or make changes to this bug.