Bug 129520 – Split UserActivity/CountedUserActivity

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Gavin Barraclough]

UserActivity currently provides an interface allowing counted, nested calls to enable/disable. In some cases it would be easier to use if it were a simpler boolean enabled/disabled interface.

[Gavin Barraclough]

Created attachment 225510 [details]
Fix

[WebKit Commit Bot]

Attachment 225510 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PageThrottler.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2627:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2629:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 3 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 225510 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=225510&action=review

> Source/WebCore/platform/UserActivity.h:52
> +    size_t m_started;

I think this should bool m_isActive;

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2629
> +    if (store.getBoolValueForKey(WebPreferencesKey::pageVisibilityBasedProcessSuppressionEnabledKey()))
> +            m_processSuppressionDisabledByWebPreference.stop();
> +    else
> +            m_processSuppressionDisabledByWebPreference.start();

FIX!!!!

[Gavin Barraclough]

Transmitting file data .................
Committed revision 164913.