Bug 129520 - Split UserActivity/CountedUserActivity
Summary: Split UserActivity/CountedUserActivity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-28 17:03 PST by Gavin Barraclough
Modified: 2014-03-01 00:44 PST (History)
1 user (show)

See Also:

Attachments
Fix (23.68 KB, patch)
2014-02-28 17:14 PST, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-02-28 17:03:12 PST 
UserActivity currently provides an interface allowing counted, nested calls to enable/disable. In some cases it would be easier to use if it were a simpler boolean enabled/disabled interface.
Comment 1 Gavin Barraclough 2014-02-28 17:14:21 PST 
Created attachment 225510 [details]
Fix
Comment 2 WebKit Commit Bot 2014-02-28 17:17:03 PST 
Attachment 225510 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PageThrottler.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2627:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2629:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 3 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2014-02-28 18:17:31 PST 
Comment on attachment 225510 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=225510&action=review

> Source/WebCore/platform/UserActivity.h:52
> +    size_t m_started;

I think this should bool m_isActive;

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2629
> +    if (store.getBoolValueForKey(WebPreferencesKey::pageVisibilityBasedProcessSuppressionEnabledKey()))
> +            m_processSuppressionDisabledByWebPreference.stop();
> +    else
> +            m_processSuppressionDisabledByWebPreference.start();

FIX!!!!
Comment 4 Gavin Barraclough 2014-03-01 00:44:09 PST 
Transmitting file data .................
Committed revision 164913.